Bug 63191

Summary:

accessibility/aria-labelledby-overrides-aria-label.html failing on Windows since it was added

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Tools / Tests

Assignee:

Alice Boxhall <aboxhall>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, cfleizach, webkit.review.bot

Priority:

Keywords:

LayoutTestFailure

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

URL:

http://build.webkit.org/results/Windows 7 Release (Tests)/r89261 (13941)/results.html

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Adam Roben (:aroben)

Reported 2011-06-22 15:17:14 PDT

accessibility/aria-labelledby-overrides-aria-label.html failing on Windows since it was added in r89204. http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r89261%20(13941)/results.html

Attachments
Patch (1.91 KB, patch) 2011-06-24 20:56 PDT, Alice Boxhall	no flags	Details Formatted Diff Diff
Patch (16.16 KB, patch) 2011-06-27 18:33 PDT, Alice Boxhall	no flags	Details Formatted Diff Diff
Patch (7.57 KB, patch) 2011-06-28 21:45 PDT, Alice Boxhall	no flags	Details Formatted Diff Diff
Patch (2.33 KB, patch) 2011-06-29 18:33 PDT, Alice Boxhall	no flags	Details Formatted Diff Diff
Patch (1.48 KB, patch) 2011-06-29 18:49 PDT, Alice Boxhall	no flags	Details Formatted Diff Diff
Patch (7.88 KB, patch) 2011-06-29 19:04 PDT, Alice Boxhall	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

chris fleizach

Comment 1 2011-06-22 15:28:22 PDT

Test needs to be updated likely

Adam Roben (:aroben)

Comment 2 2011-06-23 06:52:35 PDT

Landed expected failure results Committed r89565: <http://trac.webkit.org/changeset/89565>

chris fleizach

Comment 3 2011-06-24 15:14:39 PDT

Alice, do you have an update on this

Alice Boxhall

Comment 4 2011-06-24 20:56:07 PDT

Created attachment 98573 [details] Patch

Alice Boxhall

Comment 5 2011-06-24 20:58:22 PDT

Comment on attachment 98573 [details] Patch Hm, that didn't work as I had hoped. I have moved the test in to platform/win and platform/mac, but I still need to run it on Windows to generate the appropriate expectations. I will take another look on Monday Sydney time and hopefully successfully upload the patch then.

Alice Boxhall

Comment 6 2011-06-27 18:33:15 PDT

Created attachment 98839 [details] Patch

Alice Boxhall

Comment 7 2011-06-27 18:34:44 PDT

Comment on attachment 98573 [details] Patch Interim patch; will update Windows test and expectations from Windows machine.

Adam Roben (:aroben)

Comment 8 2011-06-28 08:23:51 PDT

Comment on attachment 98839 [details] Patch Seems like the Windows results need to be updated, not just deleted. Maybe that's what you meant by "interim"? If so, you probably shouldn't have marked the patch r?. It's really unfortunate that we have to duplicate the test for the two platforms. Maybe we should just dump the attributes instead of using shouldBe? Then each platform could have its own expected results using the same test and you wouldn't have any FAIL text.

Alice Boxhall

Comment 9 2011-06-28 16:43:44 PDT

(In reply to comment #8) > (From update of attachment 98839 [details]) > Seems like the Windows results need to be updated, not just deleted. Maybe that's what you meant by "interim"? If so, you probably shouldn't have marked the patch r?. Yes; sorry, I should have passed --no-review and forgot. But yes, that is what I meant by "interim" (and I did add that I intended to update the test and expectations from my Windows machine). > It's really unfortunate that we have to duplicate the test for the two platforms. Maybe we should just dump the attributes instead of using shouldBe? Then each platform could have its own expected results using the same test and you wouldn't have any FAIL text. Ah, that would be a better solution, indeed. I will do so and update the patch.

Alice Boxhall

Comment 10 2011-06-28 21:45:54 PDT

Created attachment 99033 [details] Patch

Alice Boxhall

Comment 11 2011-06-29 18:33:54 PDT

Created attachment 99201 [details] Patch

Alice Boxhall

Comment 12 2011-06-29 18:49:10 PDT

Created attachment 99205 [details] Patch

Alice Boxhall

Comment 13 2011-06-29 19:04:12 PDT

Created attachment 99209 [details] Patch