Bug 63139

Summary: Web Inspector: extract duplicated code that deals with source mappings.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch.
webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-03
none
Build fix. yurys: review+

Pavel Podivilov
Reported 2011-06-22 07:31:59 PDT
Web Inspector: extract duplicated code that deals with source mappings.
Attachments
Patch. (11.26 KB, patch)
2011-06-22 07:32 PDT, Pavel Podivilov 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cr-linux-03 (1.41 MB, application/zip)
2011-06-22 09:02 PDT, WebKit Review Bot 		no flags
Details
Build fix. (11.54 KB, patch)
2011-06-23 01:57 PDT, Pavel Podivilov 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-06-22 07:32:30 PDT
Created attachment 98170 [details] Patch.
WebKit Review Bot
Comment 2 2011-06-22 09:02:38 PDT
Comment on attachment 98170 [details] Patch. Attachment 98170 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8923548 New failing tests: http/tests/inspector/network/x-frame-options-deny.html http/tests/inspector/console-xhr-logging.html http/tests/inspector/network-preflight-options.html
WebKit Review Bot
Comment 3 2011-06-22 09:02:44 PDT
Created attachment 98179 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Pavel Podivilov
Comment 4 2011-06-23 01:57:26 PDT
Created attachment 98325 [details] Build fix. Console messages sometimes don't have url. We shouldn't try to show such messages in source frame.
Pavel Podivilov
Comment 5 2011-07-05 06:32:20 PDT
Committed r90395: <http://trac.webkit.org/changeset/90395>
Note You need to log in before you can comment on or make changes to this bug.