Bug 63106

Summary: Removed the conceit that global variables are local variables when running global code
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: oliver, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch oliver: review+, webkit-ews: commit-queue-

Geoffrey Garen
Reported 2011-06-21 16:50:41 PDT
Removed the conceit that global variables are local variables when running global code
Attachments
Patch (38.34 KB, patch)
2011-06-21 17:15 PDT, Geoffrey Garen 		oliver: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2011-06-21 17:15:55 PDT
Created attachment 98084 [details] Patch
WebKit Review Bot
Comment 2 2011-06-21 17:18:09 PDT
Attachment 98084 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/JavaScriptCore/interpreter/RegisterFile.h:40: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3 2011-06-21 17:26:28 PDT
Comment on attachment 98084 [details] Patch Attachment 98084 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8926076
Geoffrey Garen
Comment 4 2011-06-21 17:30:11 PDT
Not sure what the Qt failure is about -- seems like the bot is in a bad state?
Darin Adler
Comment 5 2011-06-21 17:35:03 PDT
Comment on attachment 98084 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98084&action=review > Source/JavaScriptCore/interpreter/RegisterFile.h:-36 > -#include <stdio.h> Looks like WebFrameProxy.cpp in WebKit2 was depending on this include to get the printf prototype.
Oliver Hunt
Comment 6 2011-06-21 17:35:47 PDT
Comment on attachment 98084 [details] Patch r=me, it would be good if you could add helper function to JSGlobalObject to add new global vars directly.
Geoffrey Garen
Comment 7 2011-06-22 13:25:27 PDT
http://trac.webkit.org/changeset/89465
Note You need to log in before you can comment on or make changes to this bug.