Bug 63069

Summary: Web Inspector: Move logic for deciding whether resource content should be base64 encoded on backend.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, ossy, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 63128    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch with fixes
none
Patch with fix none

Description Vsevolod Vlasov 2011-06-21 08:34:32 PDT 
Move logic for deciding whether resource content should be base64 encoded on backend.
Comment 1 Vsevolod Vlasov 2011-06-21 09:22:17 PDT 
Created attachment 97997 [details]
Patch
Comment 2 Pavel Feldman 2011-06-21 10:32:27 PDT 
Comment on attachment 97997 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97997&action=review

> Source/WebCore/inspector/InspectorPageAgent.cpp:493
> +                if (cachedResourceContent(cachedResource, &content, &base64Encoded) && !base64Encoded) {

Replace condition with ASSERT.
Comment 3 Vsevolod Vlasov 2011-06-21 10:45:03 PDT 
Created attachment 98009 [details]
Patch with fixes
Comment 4 WebKit Review Bot 2011-06-21 11:16:47 PDT 
Comment on attachment 98009 [details]
Patch with fixes

Clearing flags on attachment: 98009

Committed r89368: <http://trac.webkit.org/changeset/89368>
Comment 5 WebKit Review Bot 2011-06-21 11:16:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Vsevolod Vlasov 2011-06-22 06:06:08 PDT 
Created attachment 98159 [details]
Patch with fix
Comment 8 WebKit Review Bot 2011-06-22 10:52:11 PDT 
Comment on attachment 98159 [details]
Patch with fix

Clearing flags on attachment: 98159

Committed r89449: <http://trac.webkit.org/changeset/89449>
Comment 9 WebKit Review Bot 2011-06-22 10:52:15 PDT 
All reviewed patches have been landed.  Closing bug.