Bug 63069

Summary:

Web Inspector: Move logic for deciding whether resource content should be base64 encoded on backend.

Product:

WebKit

Reporter:

Vsevolod Vlasov <vsevik>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, ossy, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

63128

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch with fixes	none
Patch with fix	none

Vsevolod Vlasov

Reported 2011-06-21 08:34:32 PDT

Move logic for deciding whether resource content should be base64 encoded on backend.

Attachments
Patch (16.35 KB, patch) 2011-06-21 09:22 PDT, Vsevolod Vlasov	no flags	Details Formatted Diff Diff
Patch with fixes (16.37 KB, patch) 2011-06-21 10:45 PDT, Vsevolod Vlasov	no flags	Details Formatted Diff Diff
Patch with fix (16.38 KB, patch) 2011-06-22 06:06 PDT, Vsevolod Vlasov	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Vsevolod Vlasov

Comment 1 2011-06-21 09:22:17 PDT

Created attachment 97997 [details] Patch

Pavel Feldman

Comment 2 2011-06-21 10:32:27 PDT

Comment on attachment 97997 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97997&action=review > Source/WebCore/inspector/InspectorPageAgent.cpp:493 > + if (cachedResourceContent(cachedResource, &content, &base64Encoded) && !base64Encoded) { Replace condition with ASSERT.

Vsevolod Vlasov

Comment 3 2011-06-21 10:45:03 PDT

Created attachment 98009 [details] Patch with fixes

WebKit Review Bot

Comment 4 2011-06-21 11:16:47 PDT

Comment on attachment 98009 [details] Patch with fixes Clearing flags on attachment: 98009 Committed r89368: <http://trac.webkit.org/changeset/89368>

WebKit Review Bot

Comment 5 2011-06-21 11:16:53 PDT

All reviewed patches have been landed. Closing bug.

Csaba Osztrogonác

Comment 6 2011-06-22 04:13:34 PDT

Reopen, because it was rolled out by http://trac.webkit.org/changeset/89419 crash log: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28Tests%29/r89368%20%2830592%29/http/tests/inspector/extensions-resources-redirect-crash-log.txt

Vsevolod Vlasov

Comment 7 2011-06-22 06:06:08 PDT

Created attachment 98159 [details] Patch with fix

WebKit Review Bot

Comment 8 2011-06-22 10:52:11 PDT

Comment on attachment 98159 [details] Patch with fix Clearing flags on attachment: 98159 Committed r89449: <http://trac.webkit.org/changeset/89449>

WebKit Review Bot

Comment 9 2011-06-22 10:52:15 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.