Bug 63063 – [EFL] Use accept attribute when executing the file picker for input element

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Jongseok Yang]

The accept attribute is only used with <input type="file"> and it specifies the types of files that can be submitted through a file upload.
EFL port should use the attribute within the function "ChromeClientEfl::runOpenPanel()"

[Jongseok Yang]

Created attachment 97977 [details]
Use accept attribute for the file picker for INPUT element

[Ryuan Choi]

Good point.
I didn't know that file type should control 'accept'.

Anyway.
Could you explain little bit about why we can remove suggestedFilenames.

View in context: https://bugs.webkit.org/attachment.cgi?id=97977&action=review

> Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:429
> +    CString accept = chooser->acceptTypes().utf8();
> +    confirm = ewk_view_run_open_panel(m_view, kit(frame), chooser->allowsMultipleFiles(), accept.data(), &selectedFilenames);

And as small thing, I think that it's no need to store it into accept.

[Leandro Pereira]

Comment on attachment 97977 [details]
Use accept attribute for the file picker for INPUT element

Looks good; but please fix the naming scheme on the ewk_* files.

[Gyuyoung Kim]

Comment on attachment 97977 [details]
Use accept attribute for the file picker for INPUT element

View in context: https://bugs.webkit.org/attachment.cgi?id=97977&action=review

> Source/WebKit/efl/ewk/ewk_private.h:99
> +Eina_Bool ewk_view_run_open_panel(Evas_Object* o, Evas_Object* frame, Eina_Bool allows_multiple_files, const char* acceptTypes, Eina_List** selected_filenames);

For efl style, it is better to change acceptTypes with accept_types.

[Jongseok Yang]

Created attachment 98105 [details]
fix the naming scheme

[Jongseok Yang]

(In reply to comment #2)
> Good point.
> I didn't know that file type should control 'accept'.
> 
> Anyway.
> Could you explain little bit about why we can remove suggestedFilenames.
> 
> View in context: https://bugs.webkit.org/attachment.cgi?id=97977&action=review
> 
> > Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:429
> > +    CString accept = chooser->acceptTypes().utf8();
> > +    confirm = ewk_view_run_open_panel(m_view, kit(frame), chooser->allowsMultipleFiles(), accept.data(), &selectedFilenames);
> 
> And as small thing, I think that it's no need to store it into accept.

I had thought that suggestedFilenames was not required.
I found out the below statement from HTML4 specification and I could not find out any comment about that from HTML5
"Creates a file select control. User agents may use the value of the value attribute as the initial file name."

I think that it's just implementation choice.
If you want to use the value, I will fix that.

[Ryuan Choi]

(In reply to comment #6)
> (In reply to comment #2)
> > Good point.
> > I didn't know that file type should control 'accept'.
> > 
> > Anyway.
> > Could you explain little bit about why we can remove suggestedFilenames.
> > 
> > View in context: https://bugs.webkit.org/attachment.cgi?id=97977&action=review
> > 
> > > Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:429
> > > +    CString accept = chooser->acceptTypes().utf8();
> > > +    confirm = ewk_view_run_open_panel(m_view, kit(frame), chooser->allowsMultipleFiles(), accept.data(), &selectedFilenames);
> > 
> > And as small thing, I think that it's no need to store it into accept.
> 
> I had thought that suggestedFilenames was not required.
> I found out the below statement from HTML4 specification and I could not find out any comment about that from HTML5
> "Creates a file select control. User agents may use the value of the value attribute as the initial file name."
> 
> I think that it's just implementation choice.
> If you want to use the value, I will fix that.

Thanks, I agree with you.
I couldn't find any way to give suggestedFilenames also.

[Jongseok Yang]

Created attachment 98471 [details]
fix the naming scheme

fix the naming scheme from ewk_view.cpp

[Kent Tamura]

Comment on attachment 98471 [details]
fix the naming scheme

r- because of EWS failures.

[Jongseok Yang]

Created attachment 98666 [details]
fix build error

The cause for build error was that The FileChooser interface was changed by other-side.
I applied the new interface for FileChooser to my patch.

[Gyuyoung Kim]

Comment on attachment 98666 [details]
fix build error

LGTM.

[Kent Tamura]

Comment on attachment 98666 [details]
fix build error

Rubber-stamped by me

[WebKit Review Bot]

Comment on attachment 98666 [details]
fix build error

Clearing flags on attachment: 98666

Committed r89812: <http://trac.webkit.org/changeset/89812>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.