Bug 63043 – Change my entry from contributors to committers.

• Component: New Bugs
• Status: RESOLVED FIXED

[Naoki Takano]

Change my entry from contributors to committers.

[Naoki Takano]

Created attachment 97927 [details]
Patch

[Kent Tamura]

Comment on attachment 97927 [details]
Patch

Please try to land this change yourself to confirm your permission.

[Eric Seidel (no email)]

Comment on attachment 97927 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97927&action=review

> Tools/Scripts/webkitpy/common/config/committers.py:264
> +    Contributor("Naoki Takano", "[e-mail]", "honten"),

This is wrong.  If you're in the Committers list, your record should be a Committer object.

[Naoki Takano]

Created attachment 98448 [details]
Patch

[Naoki Takano]

Please review again.

[Eric Seidel (no email)]

Comment on attachment 98448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98448&action=review

> Tools/Scripts/webkitpy/common/config/committers.py:264
> +    Committer("Naoki Takano", "[e-mail]", "honten"),

The first entry should match your bugzilla username.  Successive entries should be emails you use for svn, ChangeLog entries, webkit lists. etc.  Sorry this isn't very well documented.  You can see in the code that bugzilla_email() returns the first email in the array.  It seems your bugzilla email is currently takano.naoki.  If you plan to change it to chromium, that's great.  But if not, you'll want to include it in your Committer entry.

[Naoki Takano]

I change bugzilla email to [e-mail].

Is it Ok?

(In reply to comment #6)
> (From update of attachment 98448 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=98448&action=review
> 
> > Tools/Scripts/webkitpy/common/config/committers.py:264
> > +    Committer("Naoki Takano", "[e-mail]", "honten"),
> 
> The first entry should match your bugzilla username.  Successive entries should be emails you use for svn, ChangeLog entries, webkit lists. etc.  Sorry this isn't very well documented.  You can see in the code that bugzilla_email() returns the first email in the array.  It seems your bugzilla email is currently takano.naoki.  If you plan to change it to chromium, that's great.  But if not, you'll want to include it in your Committer entry.

[Eric Seidel (no email)]

Comment on attachment 98448 [details]
Patch

LGTM.

[WebKit Review Bot]

Comment on attachment 98448 [details]
Patch

Rejecting attachment 98448 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2

Last 500 characters of output:
idel', u'--force']" exit_code: 1

Parsed 2 diffs from patch file(s).
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/Scripts/webkitpy/common/config/committers.py
Hunk #1 FAILED at 83.
Hunk #2 succeeded at 263 (offset 1 line).
1 out of 2 hunks FAILED -- saving rejects to file Tools/Scripts/webkitpy/common/config/committers.py.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/8933853

[Naoki Takano]

Seems conflict...

(In reply to comment #9)
> (From update of attachment 98448 [details])
> Rejecting attachment 98448 [details] from commit-queue.
> 
> Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2
> 
> Last 500 characters of output:
> idel', u'--force']" exit_code: 1
> 
> Parsed 2 diffs from patch file(s).
> patching file Tools/ChangeLog
> Hunk #1 succeeded at 1 with fuzz 3.
> patching file Tools/Scripts/webkitpy/common/config/committers.py
> Hunk #1 FAILED at 83.
> Hunk #2 succeeded at 263 (offset 1 line).
> 1 out of 2 hunks FAILED -- saving rejects to file Tools/Scripts/webkitpy/common/config/committers.py.rej
> 
> Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1
> 
> Full output: http://queues.webkit.org/results/8933853

[Naoki Takano]

Created attachment 98608 [details]
Patch

[Naoki Takano]

Comment on attachment 98608 [details]
Patch

Try again.

[WebKit Review Bot]

Comment on attachment 98608 [details]
Patch

Rejecting attachment 98608 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[WebKit Review Bot]

Comment on attachment 98608 [details]
Patch

Rejecting attachment 98608 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Naoki Takano]

Comment on attachment 98608 [details]
Patch

If I cannot land this patch, I don't have the real right to commit...

Please review and commit again.

[Dimitri Glazkov (Google)]

(In reply to comment #15)
> (From update of attachment 98608 [details])
> If I cannot land this patch, I don't have the real right to commit...
> 
> Please review and commit again.

If you're a committer, why can't you commit the patch?

[Naoki Takano]

Yes, I have.

But as you see the following error message,
> If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).
But I want to commit committers.py itself.

It's kinda egg or chicken problem:-)

(In reply to comment #16)
> (In reply to comment #15)
> > (From update of attachment 98608 [details] [details])
> > If I cannot land this patch, I don't have the real right to commit...
> > 
> > Please review and commit again.
> 
> If you're a committer, why can't you commit the patch?

[Kent Tamura]

(In reply to comment #17)
> Yes, I have.
> 
> But as you see the following error message,
> > If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).
> But I want to commit committers.py itself.
> 
> It's kinda egg or chicken problem:-)

Your commit privilege for the svn repository and committers.py are NOT related.
You should be able to commit this change by "svn commit", "git svn dcommit" without the committers.py change.  The name in committers.py is for commit-queue privilege and email autocompletion.

[Naoki Takano]

I tried landing. It looks like landing at r89779.

But strange thing is my account.

Even if I changed my account from [e-mail] to [e-mail] in bugzilla.

But svn isn't changed.

Where can I change the email for it?

Thanks,

(In reply to comment #18)
> (In reply to comment #17)
> > Yes, I have.
> > 
> > But as you see the following error message,
> > > If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).
> > But I want to commit committers.py itself.
> > 
> > It's kinda egg or chicken problem:-)
> 
> Your commit privilege for the svn repository and committers.py are NOT related.
> You should be able to commit this change by "svn commit", "git svn dcommit" without the committers.py change.  The name in committers.py is for commit-queue privilege and email autocompletion.

[Kent Tamura]

(In reply to comment #19)
> Even if I changed my account from [e-mail] to [e-mail] in bugzilla.
> But svn isn't changed.
> Where can I change the email for it?

Bugzilla account and svn privilege are not related.
If you'd like to change to honten@chromium, please contact a person who you asked to set up your commit privilege.

[Eric Seidel (no email)]

You can always list both in your Committer record.  And infact you should if you have any patches committed under your old name.  None of this is particularly important in the end.