Bug 63007

Summary: Web Inspector: Show "no content" message in network panel when resource does not have content available.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch with fixes none

Vsevolod Vlasov
Reported 2011-06-20 13:17:51 PDT
Show "no content" message in network panel when resource does not have content available.
Attachments
Patch (24.34 KB, patch)
2011-06-20 13:23 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch with fixes (26.27 KB, patch)
2011-06-21 05:26 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2011-06-20 13:23:19 PDT
Created attachment 97850 [details] Patch
Yury Semikhatsky
Comment 2 2011-06-21 02:28:35 PDT
Comment on attachment 97850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97850&action=review The change looks good except the code duplication in _ensureInnerViewShown > Source/WebCore/inspector/front-end/ResourceResponseView.js:34 > + Remove extra line. > Source/WebCore/inspector/front-end/ResourceResponseView.js:56 > + _ensureInnerViewShown: function() This method is very similar to ResourcePreviewView.prototype._ensureInnerViewShown above could you factor out common code into a new method/class and use it from both places?
Vsevolod Vlasov
Comment 3 2011-06-21 05:26:44 PDT
Created attachment 97969 [details] Patch with fixes
WebKit Review Bot
Comment 4 2011-06-23 08:56:19 PDT
Comment on attachment 97969 [details] Patch with fixes Clearing flags on attachment: 97969 Committed r89577: <http://trac.webkit.org/changeset/89577>
WebKit Review Bot
Comment 5 2011-06-23 08:56:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.