Bug 62986

Summary:

determine if Skia on Chrome Mac can return fallback fonts

Product:

WebKit

Reporter:

Cary Clark <caryclark>

Component:

Platform

Assignee:

Cary Clark <caryclark>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac (Intel)

OS:

OS X 10.6

Attachments:

Description	Flags
Patch	none

Cary Clark

Reported 2011-06-20 06:49:16 PDT

Determine if the Mac port of Chromium using Skia can return fallback fonts for complex text. (The Windows and Linux ports for Chromium do not.) See 97636 for more discussion about this.

Attachments
Patch (1.58 KB, patch) 2011-08-12 12:24 PDT, Cary Clark	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Cary Clark

Comment 1 2011-08-12 12:24:28 PDT

Created attachment 103792 [details] Patch

Cary Clark

Comment 2 2011-08-12 12:52:43 PDT

'97636' in the first description refers to https://bug-62889-attachments.webkit.org/attachment.cgi?id=97636

Kenneth Russell

Comment 3 2011-08-15 11:01:14 PDT

Comment on attachment 103792 [details] Patch Will this affect any other platforms than Mac Skia, and/or any layout tests?

Darin Fisher (:fishd, Google)

Comment 4 2011-08-15 11:04:44 PDT

Comment on attachment 103792 [details] Patch It seems a bit confusing that we have this function in three files: skia/FontSkia.cpp, chromium/FontChromiumWin.cpp, and chromium/FontLinux.cpp. It seems like our code is a bit disorganized.

Cary Clark

Comment 5 2011-08-15 11:30:54 PDT

kbr: This affects only the Mac port of Chromium using Skia. It fixes layout tests used solely by this configuration. fishd: Once the Mac port on Skia replaces the CG port, it will be easier to remove duplicate code, although since each code path uses a different glyph generator, there will be platform differences in fonts and font rendering.

WebKit Review Bot

Comment 6 2011-08-15 13:00:11 PDT

Comment on attachment 103792 [details] Patch Clearing flags on attachment: 103792 Committed r93057: <http://trac.webkit.org/changeset/93057>

WebKit Review Bot

Comment 7 2011-08-15 13:00:15 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.