Bug 62975

Summary: Refactor local variable usage in CSSFontFaceSource::getFontData
Product: WebKit Reporter: Yuzo Fujishima <yuzo>
Component: CSSAssignee: Yuzo Fujishima <yuzo>
Status: RESOLVED FIXED    
Severity: Minor CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Yuzo Fujishima
Reported 2011-06-20 03:18:33 PDT
There are two issues in the local variable usages in CSSFontFaceSource::getFontData - There are two different local variables named "fontData". - One is of type OwnPtr<SimpleFontData> where SimpleFontData* would suffice.
Attachments
Patch (4.56 KB, patch)
2011-06-20 03:25 PDT, Yuzo Fujishima 		no flags
DetailsFormatted DiffDiff
Patch (1.51 KB, patch)
2011-06-20 23:02 PDT, Yuzo Fujishima 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yuzo Fujishima
Comment 1 2011-06-20 03:25:09 PDT
Created attachment 97775 [details] Patch
Kent Tamura
Comment 2 2011-06-20 19:16:39 PDT
Comment on attachment 97775 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97775&action=review > Source/WebCore/css/CSSFontFaceSource.cpp:121 > - OwnPtr<SimpleFontData> fontData; > + SimpleFontData* fontData = 0; I don't think this change is reasonable. fontData.leakPtr() shows us that this 'fontData' object is not deleted by anyone. Your change will remove this intention.
Yuzo Fujishima
Comment 3 2011-06-20 23:02:55 PDT
Created attachment 97933 [details] Patch
Yuzo Fujishima
Comment 4 2011-06-20 23:04:10 PDT
Thank you for the review. I've reverted the second part. Can you take another look?
Kent Tamura
Comment 5 2011-06-20 23:06:39 PDT
Comment on attachment 97933 [details] Patch ok
WebKit Review Bot
Comment 6 2011-06-20 23:57:08 PDT
Comment on attachment 97933 [details] Patch Clearing flags on attachment: 97933 Committed r89340: <http://trac.webkit.org/changeset/89340>
WebKit Review Bot
Comment 7 2011-06-20 23:57:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.