Bug 62966

Summary: SharedBufferCRLFLineReader should be made more generic.
Product: WebKit Reporter: Jay Civelli <jcivelli>
Component: WebCore Misc.Assignee: Jay Civelli <jcivelli>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, joepeck, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Manually created patch
none
Another try at uploading a manual patch none

Description Jay Civelli 2011-06-19 23:08:38 PDT
The SharedBufferCRLFLineReader class is used by the MHTML parser code.
It should be made more generic so any separator (not only CRLFs) can be used.
That is needed for adding binary part support to MHTML.
Comment 1 Jay Civelli 2011-06-19 23:17:17 PDT
Created attachment 97751 [details]
Patch
Comment 2 Jay Civelli 2011-06-19 23:21:28 PDT
Created attachment 97752 [details]
Manually created patch

Created this patch manually as webkit-patch upload does not include the change to the moved files for some reason.

I have an extensive set of unit-tests for this code that I'll ad to TestWebKitAPI once I figured out how to add a dependency to WebCore in the TestWebKitAPI project.
Comment 3 Jay Civelli 2011-06-20 15:36:48 PDT
Created attachment 97870 [details]
Another try at uploading a manual patch
Comment 4 WebKit Review Bot 2011-06-20 17:36:43 PDT
Comment on attachment 97870 [details]
Another try at uploading a manual patch

Clearing flags on attachment: 97870

Committed r89321: <http://trac.webkit.org/changeset/89321>
Comment 5 WebKit Review Bot 2011-06-20 17:36:48 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Joseph Pecoraro 2011-06-20 17:56:23 PDT
This may have caused a build failure for mac.
http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Build%29/builds/36276/steps/compile-webkit/logs/stdio

Undefined symbols:
  "__ZN7WebCore23SharedBufferChunkReader9nextChunkEb", referenced from:
      __ZN7WebCoreL21retrieveKeyValuePairsEPNS_23SharedBufferChunkReaderE in MIMEHeader.o
ld: symbol(s) not found

You may just need to add that symbol to the appropriate place in Source/WebCore/WebCore.exp.in.
Comment 7 Adam Barth 2011-06-20 18:02:23 PDT
> You may just need to add that symbol to the appropriate place in Source/WebCore/WebCore.exp.in.

Will fix.
Comment 8 Adam Barth 2011-06-20 18:07:33 PDT
/me wonders how this patch got the green light from the mac-ews...
Comment 9 Adam Barth 2011-06-20 18:07:43 PDT
Committed r89325: <http://trac.webkit.org/changeset/89325>