Bug 62963

Summary: [EFL] Remove ewk_tile_matrix_updates_process() call from _ewk_tiled_backing_store_item_process_idler_cb()
Product: WebKit Reporter: KwangHyuk <hyuki.kim>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: antognolli+webkit, gyuyoung.kim, gyuyoung.kim, kenneth, leandro, lucas.de.marchi, rakuco, sangseok.lim, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
propose simple patch
none
patch with newest file none

KwangHyuk
Reported 2011-06-19 22:24:44 PDT
_ewk_tiled_backing_store_item_process_idler_cb() doesn't need to call ewk_tile_matrix_updates_process() since this was done by repaint_process when invalidate reqeuest is occurred. Pre-render better to focus on pre-render itself.
Attachments
propose simple patch (1.68 KB, patch)
2011-06-20 01:02 PDT, KwangHyuk 		no flags
DetailsFormatted DiffDiff
patch with newest file (1.61 KB, patch)
2011-06-27 01:40 PDT, KwangHyuk 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
KwangHyuk
Comment 1 2011-06-20 01:02:33 PDT
Created attachment 97760 [details] propose simple patch
Leandro Pereira
Comment 2 2011-06-22 07:46:31 PDT
Comment on attachment 97760 [details] propose simple patch LGTM.
WebKit Review Bot
Comment 3 2011-06-27 01:14:29 PDT
Comment on attachment 97760 [details] propose simple patch Rejecting attachment 97760 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2 Last 500 characters of output: 7689c74f450e39df6c40ece443dda35d1d973df3 r89803 = 159d9a926c6dcd366b0642ba5594a04438c76c3f Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/8949170
KwangHyuk
Comment 4 2011-06-27 01:40:58 PDT
Created attachment 98681 [details] patch with newest file
Gyuyoung Kim
Comment 5 2011-06-27 01:43:03 PDT
(In reply to comment #4) > Created an attachment (id=98681) [details] > patch with newest file Do you make your patch based on latest WebKit ?
KwangHyuk
Comment 6 2011-06-27 01:44:41 PDT
>Do you make your patch based on latest WebKit ? yes, I did.
WebKit Review Bot
Comment 7 2011-06-27 01:51:23 PDT
Comment on attachment 98681 [details] patch with newest file Clearing flags on attachment: 98681 Committed r89809: <http://trac.webkit.org/changeset/89809>
Note You need to log in before you can comment on or make changes to this bug.