Bug 62917 – KURL::protocolIs() triggers an assert when the protocol contains a character that is not an ASCII letter.

• Component: New Bugs
• Status: RESOLVED DUPLICATE

[Andy Estes]

KURL::protocolIs() triggers an assert when the protocol contains a character that is not an ASCII letter.

[Andy Estes]

Created attachment 97670 [details]
Patch

[Andy Estes]

*** This bug has been marked as a duplicate of bug 61572 ***

[Andy Estes]

Comment on attachment 97670 [details]
Patch

I'm going to update this based on comments in https://bugs.webkit.org/show_bug.cgi?id=61572

[Darin Adler]

Comment on attachment 97670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97670&action=review

> Source/WebCore/platform/KURL.cpp:705
> -        if (!protocol[i] || !isLetterMatchIgnoringCase(m_string[i], protocol[i]))
> +        if (!protocol[i] || toASCIILower(m_string[i]) != protocol[i])

Need to assert that protocol[i] is not an uppercase letter. Also ought to assert that protocol[i] is not a colon character. Maybe assert that it's a legal protocol character.

The old function was faster. At the time I wrote it I was super-obsessed with being as optimized as possible. Could still use that old algorithm when the string is all letters.