Bug 62908 – Optimization: avoid call to clearRect() when bgColor is valid when painting the root background in RenderBoxModelObject::paintFillLayerExtended

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Una Sabovic]

When root layers base color is fully transparent backgroundRect was cleared before bgColor is applied.
Instead of clearing the rect we apply CompositeCopy operation when painting the background color.

[Una Sabovic]

Created attachment 97655 [details]
proposed patch

Adjustment for https://bugs.webkit.org/show_bug.cgi?id=62593 per Darin's suggestion.

[Darin Adler]

Comment on attachment 97655 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97655&action=review

> Source/WebCore/rendering/RenderBoxModelObject.cpp:745
> +        bool clearRect = false;

This local variable name sounds like “a rectangle that is clear” or a verb phrase that means “clear a rectangle”, but it’s actually a boolean flag that indicates whether we need to clear the background. I would name it shouldClearBackground or mustClearBackground.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:758
> +            CompositeOperator compositeOp = clearRect ? CompositeCopy : context->compositeOperation();

I’d name this “operation” rather than “compositeOp”.

[Eric Seidel (no email)]

Comment on attachment 97655 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97655&action=review

> Source/WebCore/ChangeLog:1
> [phone]  una sabovic  <[e-mail]>

Is your name normally written without capitals?

[Eric Seidel (no email)]

Una isn't a committer.  Should this be marked r- or cq+?

[Una Sabovic]

Created attachment 97715 [details]
proposed patch

Fixed variable names patch ready for cq now.

[WebKit Review Bot]

Comment on attachment 97715 [details]
proposed patch

Clearing flags on attachment: 97715

Committed r89221: <http://trac.webkit.org/changeset/89221>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.