Summary: | Remove LegacyDefaultOptionalArguments flag from IDL files where it would not change behavior | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Pilgrim (Google) <pilgrim> | ||||||||
Component: | WebCore JavaScript | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, darin, fishd, ossy, sam, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 62925 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Mark Pilgrim (Google)
2011-06-17 13:01:07 PDT
Created attachment 97648 [details]
Patch
Comment on attachment 97648 [details]
Patch
=
Comment on attachment 97648 [details] Patch Clearing flags on attachment: 97648 Committed r89189: <http://trac.webkit.org/changeset/89189> All reviewed patches have been landed. Closing bug. Reopen, because it broke Qt build and was rolled out by http://trac.webkit.org/changeset/89190 cc1plus: warnings being treated as errors ../../WebCore/generated/JSDOMCoreException.cpp: In function ‘JSC::EncodedJSValue WebCore::jsDOMCoreExceptionPrototypeFunctionToString(JSC::ExecState*)’: ../../WebCore/generated/JSDOMCoreException.cpp:265: error: comparison of unsigned expression < 0 is always false It broke other bots too, not only the Qt. Please respect contributing rules try to keep the tree green: http://www.webkit.org/coding/contributing.html "Your change must at least compile on all platforms." Thanks Ossy. I wonder why the qt ews bot didn't warn us. :( (In reply to comment #7) > Thanks Ossy. I wonder why the qt ews bot didn't warn us. :( What about the commit bot? Is this happening because the commit bot now uses V8 instead of JSC? > What about the commit bot? Is this happening because the commit bot now uses V8 instead of JSC?
As the patch built fine on gtk and win, it seems more likely to be a compiler difference than a JSC/V8 difference.
(In reply to comment #9) > > What about the commit bot? Is this happening because the commit bot now uses V8 instead of JSC? > > As the patch built fine on gtk and win, it seems more likely to be a compiler difference than a JSC/V8 difference. It’s a combination of both. A compiler warning in JSC-generated code. Created attachment 97776 [details]
warning fix
"if (exec->argumentCount() < 0" was incorrect, because it is always false.
With the attached fix non-V8 builds will be happy.
Created attachment 97832 [details]
Patch
Combined patch with warning fix. Thanks Ossy for debugging. Comment on attachment 97832 [details]
Patch
Ok. Let's give this version a try.
Comment on attachment 97832 [details] Patch Clearing flags on attachment: 97832 Committed r89269: <http://trac.webkit.org/changeset/89269> All reviewed patches have been landed. Closing bug. |