| Summary: | Playing video from the manifest crashes on Windows | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | adachan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Jer Noble
2011-06-17 12:45:44 PDT
Created attachment 97639 [details]
Patch
One thing I overlooked: in the method above, QTMovie::loadPath(), should we null check cfURL and urlStringRef before releasing also? Can use RetainPtr also. Comment on attachment 97639 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97639&action=review > Source/WebCore/html/HTMLMediaElement.cpp:694 > +#if USE(CF) && PLATFORM(WIN) > + RetainPtr<CFStringRef> cfPath(AdoptCF, path.createCFString()); > + RetainPtr<CFURLRef> cfURL(AdoptCF, CFURLCreateWithFileSystemPath(0, cfPath.get(), kCFURLWindowsPathStyle, false)); > + KURL url(cfURL.get()); > +#else > KURL url; > > url.setProtocol("file"); > url.setPath(path); > +#endif This is probably the best short term fix. But longer term we would like a helper function that does this. (In reply to comment #3) > One thing I overlooked: in the method above, QTMovie::loadPath(), should we null check cfURL and urlStringRef before releasing also? Yes, we should. This patch adds null-checks there as well. > Can use RetainPtr also. Unfortunately, we can't use RetainPtr from within the QTMovie subproject. This is because of the (ridiculous) way QuickTime includes work; they have their own versions of CF headers which conflict with the AAS versions. Committed r89172: <http://trac.webkit.org/changeset/89172> Created attachment 98041 [details]
Patch
|