Bug 62899 – [UNIX] Don't use WebCore::PluginPackage to get plugin information

• Component: WebKit2
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

The problem is that both PluginPackage in WebCore and NetscapePluginModule in webkit2 install their own netscape browser functions and that can cause conflicts in some situations.

[Carlos Garcia Campos]

Created attachment 97633 [details]
Patch

[Carlos Garcia Campos]

Created attachment 97790 [details]
Patach rebased to current git master

It seems previous patch didn't apply, this one has been rebased to current git master so it should apply.

[Martin Robinson]

Comment on attachment 97790 [details]
Patach rebased to current git master

View in context: https://bugs.webkit.org/attachment.cgi?id=97790&action=review

Looks good, but please take a look at the following suggestions before landing.

> Source/WebKit2/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:104
> +        Vector<String> mime;

Maybe call this something like mimeTypeParts.

> Source/WebKit2/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:116
> +        Vector<String> extensions;
> +        if (mime.size() > 1) {
> +            mime[1].split(UChar(','), false, extensions);
> +            mimeInfo.extensions = extensions;

Can you just pass mimeInfo.extensions to the split call here?

[Carlos Garcia Campos]

Committed r89256: <http://trac.webkit.org/changeset/89256>