Bug 62899

Summary: [UNIX] Don't use WebCore::PluginPackage to get plugin information
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Gtk, Qt
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patach rebased to current git master mrobinson: review+

Description Carlos Garcia Campos 2011-06-17 12:13:19 PDT 
The problem is that both PluginPackage in WebCore and NetscapePluginModule in webkit2 install their own netscape browser functions and that can cause conflicts in some situations.
Comment 1 Carlos Garcia Campos 2011-06-17 12:17:42 PDT 
Created attachment 97633 [details]
Patch
Comment 2 Carlos Garcia Campos 2011-06-20 06:05:38 PDT 
Created attachment 97790 [details]
Patach rebased to current git master

It seems previous patch didn't apply, this one has been rebased to current git master so it should apply.
Comment 3 Martin Robinson 2011-06-20 09:57:35 PDT 
Comment on attachment 97790 [details]
Patach rebased to current git master

View in context: https://bugs.webkit.org/attachment.cgi?id=97790&action=review

Looks good, but please take a look at the following suggestions before landing.

> Source/WebKit2/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:104
> +        Vector<String> mime;

Maybe call this something like mimeTypeParts.

> Source/WebKit2/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:116
> +        Vector<String> extensions;
> +        if (mime.size() > 1) {
> +            mime[1].split(UChar(','), false, extensions);
> +            mimeInfo.extensions = extensions;

Can you just pass mimeInfo.extensions to the split call here?
Comment 4 Carlos Garcia Campos 2011-06-20 10:49:29 PDT 
Committed r89256: <http://trac.webkit.org/changeset/89256>