Bug 62884

Summary: Assertion failure in SVGTextLayoutEngine constructor (!m_layoutAttributes.isEmpty())
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: SVGAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://code.google.com/p/chromium/issues/detail?id=84048
Attachments:
Description Flags
Proposed fix: do not layout if you don't have any layout attributes. darin: review+, webkit.review.bot: commit-queue-

Description Julien Chaffraix 2011-06-17 10:58:06 PDT 
It looks like we can have an empty layoutAttributes in some cases. The URL has a reduced test case.

Patch forthcoming.
Comment 1 Julien Chaffraix 2011-06-17 13:00:06 PDT 
Created attachment 97641 [details]
Proposed fix: do not layout if you don't have any layout attributes.
Comment 2 WebKit Review Bot 2011-06-17 19:44:03 PDT 
Comment on attachment 97641 [details]
Proposed fix: do not layout if you don't have any layout attributes.

Rejecting attachment 97641 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 1

Last 500 characters of output:
  return self.open(self.click(*args, **kwds))
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open
    return self._mech_open(url, data, timeout=timeout)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open
    raise response
webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error

Full output: http://queues.webkit.org/results/8873023
Comment 3 Nikolas Zimmermann 2011-06-17 23:39:30 PDT 
Good catch, thanks Julien - generated content & SVG Text did not play well together.
Comment 4 Nikolas Zimmermann 2011-06-17 23:53:54 PDT 
Oh, this was already landed manually by Julien in r89183. Closing bug.
Comment 5 Julien Chaffraix 2011-06-19 07:57:07 PDT 
(Adding Eric as there was some hogs with the commit queue, Eric see this comment and comment #2 for reference)

(In reply to comment #4)
> Oh, this was already landed manually by Julien in r89183. Closing bug.

Good catch, thanks! However I did not land the patch. The commit queue did but got an error before closing the bug. Not sure which component returned a 500 response.