Bug 62880

Summary:

Remove run-bindings-tests

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

eric, pilgrim, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	abarth: review-

Adam Barth

Reported 2011-06-17 10:47:42 PDT

Remove run-bindings-tests

Attachments
Patch (513.03 KB, patch) 2011-06-17 10:56 PDT, Adam Barth	abarth: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2011-06-17 10:49:20 PDT

Has it been folded into something else? or is it just dead?

Adam Barth

Comment 2 2011-06-17 10:56:15 PDT

The results files are out of date and I don't think we've gotten any value out of the test suite. It seemed like a good idea at the time, but I think now that I was wrong.

Adam Barth

Comment 3 2011-06-17 10:56:44 PDT

Created attachment 97619 [details] Patch

Eric Seidel (no email)

Comment 4 2011-06-17 11:00:23 PDT

Odd. I still think this is a good idea for people wanting to change the generator. But I may just be clinging to false hopes.

Darin Adler

Comment 5 2011-06-17 11:02:15 PDT

Comment on attachment 97619 [details] Patch I love these tests. They are very helpful to me any time I am changing the binding scripts to make sure I didn’t break platforms other than the ones I am testing on.

Adam Barth

Comment 6 2011-06-17 11:05:48 PDT

Comment on attachment 97619 [details] Patch Ok. If you find them useful we should keep them.

Eric Seidel (no email)

Comment 7 2011-06-17 11:08:55 PDT

Why don't we just run them on a buildbot? Then they'd stop breaking (which seems to make Adam sad), and yet stay around and be useful (which seems to make Darin happy). :)

Adam Barth

Comment 8 2011-06-17 11:20:10 PDT

(In reply to comment #7) > Why don't we just run them on a buildbot? Then they'd stop breaking (which seems to make Adam sad), and yet stay around and be useful (which seems to make Darin happy). :) That's probably a good idea. They're insanely fast.

Eric Seidel (no email)

Comment 9 2011-06-20 11:31:49 PDT

(In reply to comment #8) > (In reply to comment #7) > > Why don't we just run them on a buildbot? Then they'd stop breaking (which seems to make Adam sad), and yet stay around and be useful (which seems to make Darin happy). :) > > That's probably a good idea. They're insanely fast. Done. Bug 63001.

Note You need to log in before you can comment on or make changes to this bug.