Summary: | HEAD build broken 12/29/2005 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Dalrymple <markd> | ||||
Component: | WebKit API | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Blocker | ||||||
Priority: | P1 | ||||||
Version: | 420+ | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Attachments: |
|
Description
Mark Dalrymple
2005-12-29 12:50:33 PST
Sorry!
I think ch shouldn't be used there, but rather the check should be
if (offset != 0 && !isSpace(*(UniChar *)(((char *)characters) + offset - 1)) && style-
>wordSpacing)
I'm going to compile and test this change right away.
Created attachment 5356 [details]
Fetch previous character from the buffer instead of using uninitialized ch
The funny pointer math is required because offset is given in bytes, and I
think it's neater to use "-1" rather than "-2" since it's 1 UniChar behind.
Comment on attachment 5356 [details]
Fetch previous character from the buffer instead of using uninitialized ch
Yes, this fixes the bug. And I'll trust mitz on the correctness of the logic
here. r=me.
|