Bug 62861

Summary: Web Inspector: REGRESSION: Breakpoint is missed
Product: WebKit Reporter: Andrey Adaikin <aandrey>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, podivilov, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch. pfeldman: review+

Andrey Adaikin
Reported 2011-06-17 06:37:38 PDT
A breakpoint on the last line of a <script>...</script> block is missed. For example: <script> console.log("TRY TO SET A BREAKPOINT HERE - IT IS OK"); console.log("TRY TO SET A BREAKPOINT HERE - IT WILL BE MISSED"); </script> The bug exists in Chrome 13.0.782.15 (Official Build 88529) dev, and Chrome v14
Attachments
Patch. (6.40 KB, patch)
2011-06-17 10:02 PDT, Pavel Podivilov 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-06-17 10:02:03 PDT
Created attachment 97610 [details] Patch.
Andrey Adaikin
Comment 2 2011-06-17 10:40:34 PDT
View in context: https://bugs.webkit.org/attachment.cgi?id=97610&action=review > Source/WebCore/inspector/InspectorDebuggerAgent.cpp:267 > + if (breakpoint.lineNumber < script.startLine || script.endLine + 1 <= breakpoint.lineNumber) maybe: script.endLine < breakpoint.lineNumber ?
Andrey Adaikin
Comment 3 2011-06-17 10:42:19 PDT
btw, what about this case: <script> console.log("TRY TO SET A BREAKPOINT HERE");</script> ?
Pavel Podivilov
Comment 4 2011-06-21 03:30:42 PDT
Committed r89346: <http://trac.webkit.org/changeset/89346>
Note You need to log in before you can comment on or make changes to this bug.