Summary: | Web Inspector: Highlighting broken while navigating the tabs | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrey Adaikin <aandrey> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Podivilov <podivilov> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, podivilov, rik, timothy, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Andrey Adaikin
2011-06-17 06:35:00 PDT
Updated steps to repro: 1. Go to a web page, open the DevTools on the Scripts tab 2. Open console by pressing the ESC button 3. Go to Console tab 4. Hit refresh (Ctrl+F5) on the Console tab 5. Go to the Scripts tab, and observe that the script is not highlighted I remember I fixed the very same bug here: http://trac.webkit.org/browser/trunk/Source/WebCore/inspector/front-end/inspector.js#L1195 but somebody added this code snippet before it: if (!panel.canShowAnchorLocation(anchor)) return false; thus I guess the bug appeared again. And there should be no horizontal scroll in the Scripts panel bar to repro this bug. (In reply to comment #2) > I remember I fixed the very same bug here: > http://trac.webkit.org/browser/trunk/Source/WebCore/inspector/front-end/inspector.js#L1195 > > but somebody added this code snippet before it: > > if (!panel.canShowAnchorLocation(anchor)) > return false; > > thus I guess the bug appeared again. It's unrelated since you don't click on the link in your scenario, you just switch tabs. I think this bug was there for a very long time. Yes, you right. Then the this.drawer.immediatelyFinishAnimation() call should be removed from there, and added to the place where you switch the panels. Created attachment 98689 [details]
Patch.
Committed r90096: <http://trac.webkit.org/changeset/90096> |