Summary: | Exclude isCALayerContext check if building Chrome to use Skia on Mac. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Cary Clark <caryclark> | ||||
Component: | New Bugs | Assignee: | Cary Clark <caryclark> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | mihaip, sail, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Cary Clark
2011-06-17 06:30:43 PDT
Created attachment 97590 [details]
Patch
I'm not that familiar with the Mac Skia efforts. Would it be safer (in case there are other callsites) to change GraphicsContext.h to add a declaration of isCALayerContext when USE(SKIA) is defined to always return false? This is the only call-site. Eventually, the code will become scrollAnimator->setIsDrawingIntoLayer(false); (no compile-time condition) once all Skia patches are landed, so there's little value in adding a dummy isCALayerContext() call. (that is, this is the only call-site that is compiled when USE(SKIA) is defined on the Chromium Mac build.) The commit-queue encountered the following flaky tests while processing attachment 97590 [details]: fast/dom/NodeList/5725058-crash-scenario-1.html bug 62577 (authors: mrowe@apple.com and sam@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 97590 [details] Patch Clearing flags on attachment: 97590 Committed r89147: <http://trac.webkit.org/changeset/89147> All reviewed patches have been landed. Closing bug. |