Detect mixed-scripting involving https -> http redirects

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Chris Evans]

The current detection is thwarted by a redirect.

[Chris Evans]

Created attachment 97550 [details]
Patch

[WebKit Review Bot]

Attachment 97550 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http..." exit_code: 1

Source/WebCore/loader/cache/CachedResourceLoader.cpp:202:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Evans]

Created attachment 97551 [details]
Patch

[Chris Evans]

(Style nit fixed in 2nd patch)

[WebKit Review Bot]

Comment on attachment 97551 [details]
Patch

Attachment 97551 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8881481

[Chris Evans]

Created attachment 97607 [details]
Patch

Fix Mac compile warning.

[Adam Barth]

Comment on attachment 97607 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97607&action=review

This isn't a complete solution, but it's a good step forward.

> Source/WebCore/loader/cache/CachedResourceLoader.cpp:202
> +bool CachedResourceLoader::checkMixedContent(CachedResource::Type type, const KURL& url) const

I'd call this function checkInsecureContent to be consistent with the other terminology we're using.

[Chris Evans]

Created attachment 97629 [details]
Patch

Fix function name.

[WebKit Review Bot]

Comment on attachment 97629 [details]
Patch

Clearing flags on attachment: 97629

Committed r89155: <http://trac.webkit.org/changeset/89155>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.