Bug 62818 – FrameLoader doesn't need completeURL or baseURL

• Component: New Bugs
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

FrameLoader doesn't need completeURL or baseURL

[Eric Seidel (no email)]

Created attachment 97493 [details]
Patch

[Adam Barth]

Comment on attachment 97493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97493&action=review

> Source/WebCore/html/HTMLPlugInImageElement.cpp:103
> +    ASSERT(frameLoader);

This assert is kind of pointless.

> Source/WebCore/inspector/InspectorPageAgent.cpp:320
> -    frame->loader()->changeLocation(mainFrame->document()->securityOrigin(), frame->loader()->completeURL(url), "", false, false);
> +    frame->loader()->changeLocation(mainFrame->document()->securityOrigin(), mainFrame->document()->completeURL(url), "", false, false);

Why mainFrame and not frame ?

[WebKit Review Bot]

Comment on attachment 97493 [details]
Patch

Attachment 97493 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8877332

[WebKit Review Bot]

Comment on attachment 97493 [details]
Patch

Attachment 97493 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8872318

[Eric Seidel (no email)]

Created attachment 97506 [details]
Patch

[WebKit Review Bot]

Comment on attachment 97506 [details]
Patch

Attachment 97506 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8876353

[Eric Seidel (no email)]

Created attachment 97509 [details]
Patch

[Adam Barth]

Comment on attachment 97509 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97509&action=review

> Source/WebCore/bindings/generic/GenericBinding.h:61
> -    return frame->loader()->completeURL(relativeURL);
> +    return frame->document()->completeURL(relativeURL);

I probably wrote this line of code (or at least reviewed it).  :(

[WebKit Review Bot]

Comment on attachment 97509 [details]
Patch

Attachment 97509 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8877354

[Eric Seidel (no email)]

Created attachment 97511 [details]
Patch

[WebKit Review Bot]

Comment on attachment 97511 [details]
Patch

Clearing flags on attachment: 97511

Committed r89079: <http://trac.webkit.org/changeset/89079>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.