Bug 62815

Summary: [Qt] Fix wrong framework generation on MacOS when inside Qt 4.8.
Product: WebKit Reporter: Alexis Menard (darktears) <menard>
Component: WebKit QtAssignee: Alexis Menard (darktears) <menard>
Status: RESOLVED FIXED    
Severity: Critical CC: ademar, webkit.review.bot
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
Attachments:
Description Flags
Patch
none
Patch none

Alexis Menard (darktears)
Reported 2011-06-16 13:41:16 PDT
[Qt] Fix wrong framework generation on MacOS when inside Qt 4.8.
Attachments
Patch (5.72 KB, patch)
2011-06-16 13:48 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Patch (5.85 KB, patch)
2011-06-16 14:00 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexis Menard (darktears)
Comment 1 2011-06-16 13:48:21 PDT
Created attachment 97486 [details] Patch
Alexis Menard (darktears)
Comment 2 2011-06-16 14:00:42 PDT
Created attachment 97490 [details] Patch
Alexis Menard (darktears)
Comment 3 2011-06-16 14:01:54 PDT
I'll be happy to rethink the entire modularization thing with Qt5 :D.
Andreas Kling
Comment 4 2011-06-17 07:28:22 PDT
Comment on attachment 97490 [details] Patch rs=me
WebKit Review Bot
Comment 5 2011-06-17 08:08:22 PDT
Comment on attachment 97490 [details] Patch Clearing flags on attachment: 97490 Committed r89137: <http://trac.webkit.org/changeset/89137>
WebKit Review Bot
Comment 6 2011-06-17 08:08:26 PDT
All reviewed patches have been landed. Closing bug.
Ademar Reis
Comment 7 2011-06-20 06:30:39 PDT
Revision r89137 cherry-picked into qtwebkit-2.2 with commit b64ad02 <http://gitorious.org/webkit/qtwebkit/commit/b64ad02>
Note You need to log in before you can comment on or make changes to this bug.