Summary: | Add an assertion that percent height box is unregistered correctly | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||||
Component: | Layout and Rendering | Assignee: | Kent Tamura <tkent> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dglazkov, jamesr, mitz, webkit.review.bot | ||||||
Priority: | P3 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Kent Tamura
2011-06-16 02:03:47 PDT
Created attachment 97424 [details]
Patch
Comment on attachment 97424 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97424&action=review > Source/WebCore/rendering/RenderBlock.cpp:3424 > +#ifndef NDEBUG I found that we have a preprocessor symbol called ASSERT_DISABLED. Created attachment 99680 [details]
Patch 2
Chekcs ASSERT_DISABLED
Comment on attachment 97424 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97424&action=review >> Source/WebCore/rendering/RenderBlock.cpp:3424 >> +#ifndef NDEBUG > > I found that we have a preprocessor symbol called ASSERT_DISABLED. Yes, ASSERT_DISABLED is better. I have updated the patch. Comment on attachment 99680 [details]
Patch 2
Assertion failure should be better than use-after-free.
Comment on attachment 99680 [details] Patch 2 Clearing flags on attachment: 99680 Committed r90388: <http://trac.webkit.org/changeset/90388> All reviewed patches have been landed. Closing bug. |