Bug 62792

Summary: Add an assertion that percent height box is unregistered correctly
Product: WebKit Reporter: Kent Tamura <tkent>
Component: Layout and RenderingAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, jamesr, mitz, webkit.review.bot
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch 2 none

Kent Tamura
Reported 2011-06-16 02:03:47 PDT
gPercentHeightDescendantsMap in RenderBlock tracks boxes with a percent height. It would be possible that gPercentHeightDescendantsMap contains a stale pointer if a height of a RenderStyle was updated in layout(). I don't think we have such code at this moment. I had this problem with my local change.
Attachments
Patch (3.54 KB, patch)
2011-06-16 02:07 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 2 (3.48 KB, patch)
2011-07-05 01:44 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2011-06-16 02:07:56 PDT
Created attachment 97424 [details] Patch
Hajime Morrita
Comment 2 2011-07-04 23:18:58 PDT
Comment on attachment 97424 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97424&action=review > Source/WebCore/rendering/RenderBlock.cpp:3424 > +#ifndef NDEBUG I found that we have a preprocessor symbol called ASSERT_DISABLED.
Kent Tamura
Comment 3 2011-07-05 01:44:20 PDT
Created attachment 99680 [details] Patch 2 Chekcs ASSERT_DISABLED
Kent Tamura
Comment 4 2011-07-05 01:45:43 PDT
Comment on attachment 97424 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97424&action=review >> Source/WebCore/rendering/RenderBlock.cpp:3424 >> +#ifndef NDEBUG > > I found that we have a preprocessor symbol called ASSERT_DISABLED. Yes, ASSERT_DISABLED is better. I have updated the patch.
Hajime Morrita
Comment 5 2011-07-05 01:49:30 PDT
Comment on attachment 99680 [details] Patch 2 Assertion failure should be better than use-after-free.
WebKit Review Bot
Comment 6 2011-07-05 02:31:37 PDT
Comment on attachment 99680 [details] Patch 2 Clearing flags on attachment: 99680 Committed r90388: <http://trac.webkit.org/changeset/90388>
WebKit Review Bot
Comment 7 2011-07-05 02:31:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.