Bug 6279

Summary: Patch: give internal functions names (KJS merge)
Product: WebKit Reporter: Maks Orlovich <maksim>
Component: JavaScriptCoreAssignee: Maciej Stachowiak <mjs>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Other   
OS: Linux   
Bug Depends on:    
Bug Blocks: 7383    
Attachments:
Description Flags
patch (sorta preliminary)
none
improved patch that applies to trunk and does more cleanup darin: review+

Maks Orlovich
Reported 2005-12-28 14:54:57 PST
The attached is a preliminary patch to give builtin functions names, and have them print out in the way mozilla and KJS testsuites expect (mostly --- some mozilla testcases has a requirement on body indenting, but this fixes a couple). I'll probably rediff it against actual JSC later on. This basically does: -Move keeping track of name into InternalFunctionImp -Set the name when grabbing functions from hashtable -Set the name of manual managed properties by hand -Use the name when printing internal functions Based on the work done by David Faure.
Attachments
patch (sorta preliminary) (24.13 KB, patch)
2005-12-28 14:56 PST, Maks Orlovich 		no flags
DetailsFormatted DiffDiff
improved patch that applies to trunk and does more cleanup (125.08 KB, patch)
2006-02-20 22:12 PST, Maciej Stachowiak 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Maks Orlovich
Comment 1 2005-12-28 14:56:18 PST
Created attachment 5345 [details] patch (sorta preliminary)
Maciej Stachowiak
Comment 2 2006-02-20 22:12:16 PST
Created attachment 6635 [details] improved patch that applies to trunk and does more cleanup
Darin Adler
Comment 3 2006-02-20 23:06:24 PST
Comment on attachment 6635 [details] improved patch that applies to trunk and does more cleanup Why does object_object.h now have to include function.h? Why does kjs_binding.h now have to include function_object.h and internal.h? r=me anyway
Geoffrey Garen
Comment 4 2006-02-20 23:18:33 PST
Comment on attachment 6635 [details] improved patch that applies to trunk and does more cleanup Maciej and I talked about some changes on IRC, which I pre-emptively r+
Maciej Stachowiak
Comment 5 2006-02-20 23:42:45 PST
> Why does object_object.h now have to include function.h? No reason - fixed. > Why does kjs_binding.h now have to include function_object.h and internal.h? No reason any more. Removed.
Darin Adler
Comment 6 2006-02-21 07:06:33 PST
Maciej landed this last night.
Note You need to log in before you can comment on or make changes to this bug.