Bug 62763

Summary: WKSecurityOriginGetProtocol and WKSecurityOriginGetHost are named wrong because they return copied strings
Product: WebKit Reporter: John Sullivan <sullivan>
Component: WebKit2Assignee: John Sullivan <sullivan>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch to update the two names to correctly reflect their behavior. sam: review+

John Sullivan
Reported 2011-06-15 16:07:29 PDT
WKSecurityOriginGetProtocol and WKSecurityOriginGetHost are named as if they return a pre-existing object, but they actually return copied strings. This leads to leaks in callers that don't know to take ownership responsibility for the return values. <rdar://problem/9618071>
Attachments
Patch to update the two names to correctly reflect their behavior. (2.66 KB, patch)
2011-06-15 16:10 PDT, John Sullivan 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
John Sullivan
Comment 1 2011-06-15 16:10:09 PDT
Created attachment 97373 [details] Patch to update the two names to correctly reflect their behavior.
John Sullivan
Comment 2 2011-06-15 16:18:57 PDT
http://trac.webkit.org/changeset/88983
Note You need to log in before you can comment on or make changes to this bug.