Bug 62752 – [GTK] Transition to Mozilla named cursors have incorrect hotspot and rendering

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Martin Robinson]

When the view cursor switches to a Mozilla named cursor, the pointer jumps to a different location. Additionally the hotspot is incorrect. This is visible when dragging the slider on today's Google doodle (lunar eclipse). These are cached here for posterity: http://www.google.com/logos/. You can also see this in Source/WebCore/manual-tests/cur-hotspot.html.

[Martin Robinson]

Created attachment 97357 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 97357 [details]
Patch

Makes sense.  How do we test this?

[Martin Robinson]

(In reply to comment #2)
> (From update of attachment 97357 [details])
> Makes sense.  How do we test this?

I don't think there are automated tests for cursors, so we just have to rely on the manual test at Source/WebCore/manual-tests/cursor.html.

[Daniel Bates]

Comment on attachment 97357 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97357&action=review

> Source/WebCore/ChangeLog:11
> +        * manual-tests/cursor.html: The grab cursor div covers this change.

Nit: On my first read of this commit message I thought you that you were adding this test since you use the same '*:' style as prepare-ChangeLog. I suggest writing a complete sentence instead of using the same notation. Maybe something like: "This change is covered by the grab cursor div in manual-tests/cursor.html."

[Martin Robinson]

Committed r90788: <http://trac.webkit.org/changeset/90788>

[Martin Robinson]

Thanks for the review! I used the line: "No new tests. This is covered by manual-tests/cursor.html."