Bug 62719

Summary: [Spellcheck API] Refactoring: Push down SpellCheck API part of DocumentMarkerController to html module
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: HTML EditingAssignee: Hajime Morrita <morrita>
Status: RESOLVED INVALID    
Severity: Normal CC: dglazkov, hbono, rniwa, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fixed mac build none

Hajime Morrita
Reported 2011-06-15 04:44:27 PDT
DocumentMarkerController is a part of dom/ directory, but it includes SpellCheckRange, which is a part of html/ directly. This violates dependency assumption: dom/ should not depend on html/. Thus we need to extract html-dependent part of DocumentMarkerController to html directly.
Attachments
Patch (27.09 KB, patch)
2011-06-15 04:52 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Fixed mac build (27.71 KB, patch)
2011-06-15 19:28 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2011-06-15 04:52:17 PDT
Created attachment 97277 [details] Patch
WebKit Review Bot
Comment 2 2011-06-15 07:25:02 PDT
Comment on attachment 97277 [details] Patch Attachment 97277 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8791163
Hajime Morrita
Comment 3 2011-06-15 19:28:36 PDT
Created attachment 97387 [details] Fixed mac build
Hajime Morrita
Comment 4 2011-06-15 20:39:00 PDT
Mac build passed this. It's ready for review!
Tony Chang
Comment 5 2011-06-22 16:19:46 PDT
I believe this patch is now obsolete.
Hajime Morrita
Comment 6 2011-06-23 17:56:28 PDT
Comment on attachment 97387 [details] Fixed mac build You're right. making this obsolete. Thanks for the catch!
Note You need to log in before you can comment on or make changes to this bug.