Summary: | Web Inspector: breakpointsWithoutSourceFile values should be a maps, not arrays. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Podivilov <podivilov> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Podivilov <podivilov> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Pavel Podivilov
2011-06-15 03:46:42 PDT
Created attachment 97272 [details]
Patch.
Comment on attachment 97272 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=97272&action=review > Source/WebCore/inspector/front-end/Settings.js:-82 > - this._migrateSettings(); This code should be preserved to get rid of existing duplicates. Otherwise, inspector will be slow until next time breakpoints are persisted and override existing settings. r- for this. (In reply to comment #2) > (From update of attachment 97272 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=97272&action=review > > > Source/WebCore/inspector/front-end/Settings.js:-82 > > - this._migrateSettings(); > > This code should be preserved to get rid of existing duplicates. Otherwise, inspector will be slow until next time breakpoints are persisted and override existing settings. r- for this. If breakpoints are duplicated in local storage, chances are that inspector is slow for quite some time. Why can not it be slow just a little bit longer? From the other side, migrating the settings causes the loss of all breakpoints, even if there were no duplicates. We could introduce a threshold and nuke breakpoints only in case the value length is > 2000000 + migrate to the map. Created attachment 97433 [details]
Added a threshold to nuke breakpoints.
Committed r89135: <http://trac.webkit.org/changeset/89135> |