Bug 62697

Summary:

[CMAKE] Enable METER_TAG of HTML5

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

WebKit EFL

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

antognolli+webkit, gyuyoung.kim, kenneth, leandro, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

62211

Bug Blocks:

Attachments:

Description	Flags
Proposed Patch	none
Modified Patch	leandro: review-
Modified Patch	none

Gyuyoung Kim

Reported 2011-06-14 23:31:45 PDT

Enable meter tag among html5 features. I test this feature in http://www.quackit.com/html_5/tags/html_meter_tag.cfm Meter tag features is working well on the site.

Attachments
Proposed Patch (1.73 KB, patch) 2011-06-14 23:34 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Modified Patch (1.71 KB, patch) 2011-06-15 06:35 PDT, Gyuyoung Kim	leandro: review-	Details Formatted Diff Diff
Modified Patch (1.81 KB, patch) 2011-06-15 18:06 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Gyuyoung Kim

Comment 1 2011-06-14 23:34:39 PDT

Created attachment 97238 [details] Proposed Patch

Gyuyoung Kim

Comment 2 2011-06-14 23:55:49 PDT

Bug 62211's patch should be landed in order to work this patch.

Raphael Kubo da Costa (:rakuco)

Comment 3 2011-06-15 06:01:31 PDT

It looks OK at first glance.

Lucas De Marchi

Comment 4 2011-06-15 06:18:25 PDT

Comment on attachment 97238 [details] Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97238&action=review > ChangeLog:7 > + [EFL] Enable METER_TAG of HTML5 > + https://bugs.webkit.org/show_bug.cgi?id=62697 > + Since this is not specific to EFL, mind sending this again changing it to [CMAKE] instead of EFL? In fact the ideal would be to split this patch in the generic and specific parts, but since it's very small, I think it's better to just change to [CMAKE] and tell in the log message that it's being enabled for EFL port.

Gyuyoung Kim

Comment 5 2011-06-15 06:35:08 PDT

Created attachment 97285 [details] Modified Patch

Leandro Pereira

Comment 6 2011-06-15 08:56:18 PDT

Comment on attachment 97285 [details] Modified Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97285&action=review > ChangeLog:8 > + [CMAKE] Enable METER_TAG of HTML5 > + https://bugs.webkit.org/show_bug.cgi?id=62697 > + > + Support meter tag of html5 for EFL port. You could say "Right now, this is only enabled on the EFL port.", so that you don't repeat yourself (and add nothing to anyone else reading the changelog entry).

Gyuyoung Kim

Comment 7 2011-06-15 18:06:52 PDT

Created attachment 97381 [details] Modified Patch Leandro, ChangeLog is modified as much as I can fill. :)

Leandro Pereira

Comment 8 2011-06-16 06:52:44 PDT

Comment on attachment 97381 [details] Modified Patch LGTM.

Eric Seidel (no email)

Comment 9 2011-06-16 10:48:48 PDT

Comment on attachment 97381 [details] Modified Patch OK.

WebKit Review Bot

Comment 10 2011-06-16 11:33:43 PDT

Comment on attachment 97381 [details] Modified Patch Clearing flags on attachment: 97381 Committed r89051: <http://trac.webkit.org/changeset/89051>

WebKit Review Bot

Comment 11 2011-06-16 11:33:48 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.