Bug 62693

Summary: windowsKeyCodeForKeyEvent should be robust against NSFlagsChanged events
Product: WebKit Reporter: John Sullivan <sullivan>
Component: WebKit2Assignee: John Sullivan <sullivan>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, sam
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch to bail out of windowsKeyCodeForKeyEvent for NSFlagsChanged events adachan: review+

John Sullivan
Reported 2011-06-14 20:42:02 PDT
The function windowsKeyCodeForKeyEvent() in WebEventFactory.mm does not explicitly check for NSFlagsChanged events before calling -charactersIgnoringModifiers. -[NSEvent charactersIgnoringModifiers] throws an exception for NSFlagsChanged events. We should make this function avoid this possibility. In Radar as <rdar://problem/9601436>
Attachments
Patch to bail out of windowsKeyCodeForKeyEvent for NSFlagsChanged events (1.33 KB, patch)
2011-06-14 20:45 PDT, John Sullivan 		adachan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
John Sullivan
Comment 1 2011-06-14 20:45:55 PDT
Created attachment 97227 [details] Patch to bail out of windowsKeyCodeForKeyEvent for NSFlagsChanged events
John Sullivan
Comment 2 2011-06-14 20:53:27 PDT
Fixed in http://trac.webkit.org/changeset/88903
Sam Weinig
Comment 3 2011-06-14 21:45:02 PDT
John, is there a particular key combination that produces this exception. If so, we should consider at least documenting it here, and if possible, writing an API test for this.
John Sullivan
Comment 4 2011-06-14 21:47:17 PDT
Don’t know of the key code that’s causing the exception, but stack traces from crashes show that it is happening.
Darin Adler
Comment 5 2011-06-14 22:20:43 PDT
Wouldn’t a white list be better than a black list for event types?
Alexey Proskuryakov
Comment 6 2011-06-14 22:35:35 PDT
If this is reproducible, can you just post what event causes this, and a stack trace? A switch above this code seems to handle all keys that can cause NSFlagsChanged. And if it misses some, we should find out which ones, and return a proper Windows key code for these, not a zero.
Alexey Proskuryakov
Comment 7 2011-06-14 22:40:55 PDT
Actually, I see this info in Radar, and it seems like the NSEvent is somehow invalid. I don't know how an event could have key code 49808. Are we dealing with some sort of a memory consistency issue here?
Note You need to log in before you can comment on or make changes to this bug.