Bug 6267

Summary: Fix Number.prototype.toFixed/toExponential(undefined)
Product: WebKit Reporter: Maks Orlovich <maksim>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
patch ggaren: review+

Maks Orlovich
Reported 2005-12-27 20:26:00 PST
The attached fixes the two functions to properly handle being passed undefined as per spec, and not to exception. toFixed is supposed to handle it as 0; while toExponential has special handling; that was implemented, but was prevented from running by a wrong range check. This is tested by KJS's Number.js
Attachments
patch (1001 bytes, patch)
2005-12-27 20:26 PST, Maks Orlovich 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Maks Orlovich
Comment 1 2005-12-27 20:26:52 PST
Created attachment 5323 [details] patch
Geoffrey Garen
Comment 2 2005-12-27 21:29:43 PST
Comment on attachment 5323 [details] patch r=me The second throwError message needs the verb "be" before this lands.
Darin Adler
Comment 3 2005-12-28 10:35:04 PST
We need to land the Number.js test too with this patch -- can't land a patch without a test.
Maks Orlovich
Comment 4 2005-12-28 10:41:46 PST
Maciej landed the entire KJS testsuite.
Geoffrey Garen
Comment 5 2005-12-29 03:49:09 PST
Landed.
Note You need to log in before you can comment on or make changes to this bug.