Bug 62663

Summary: Add functions for encoding/decoding data with a known size and alignment
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch darin: review+

Anders Carlsson
Reported 2011-06-14 14:11:32 PDT
Add functions for encoding/decoding data with a known size and alignment
Attachments
Patch (3.70 KB, patch)
2011-06-14 14:13 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (3.72 KB, patch)
2011-06-14 14:35 PDT, Anders Carlsson 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-06-14 14:13:13 PDT
Created attachment 97166 [details] Patch
Darin Adler
Comment 2 2011-06-14 14:28:05 PDT
Comment on attachment 97166 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97166&action=review > Source/WebKit2/Platform/CoreIPC/ArgumentDecoder.cpp:110 > + memcpy(data, m_bufferPos, size); I don’t get it. Don’t you need to call roundUpToAlignment on m_bufferPos? Or just call alignBufferPosition instead? Don’t you need to do m_bufferPos += size?
Anders Carlsson
Comment 3 2011-06-14 14:34:53 PDT
(In reply to comment #2) > (From update of attachment 97166 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=97166&action=review > > > Source/WebKit2/Platform/CoreIPC/ArgumentDecoder.cpp:110 > > + memcpy(data, m_bufferPos, size); > > I don’t get it. > > Don’t you need to call roundUpToAlignment on m_bufferPos? Or just call alignBufferPosition instead? > Yeah, bufferIsLargeEnoughToContain should be alignBufferPosition. > Don’t you need to do m_bufferPos += size? Yes. New patch coming up.
Anders Carlsson
Comment 4 2011-06-14 14:35:11 PDT
Created attachment 97167 [details] Patch
Anders Carlsson
Comment 5 2011-06-14 14:39:36 PDT
Committed r88853: <http://trac.webkit.org/changeset/88853>
Note You need to log in before you can comment on or make changes to this bug.