| Summary: | IndexedDB: Use fileExists() first when checking if SQLite db exists | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Hans Wennborg <hans> | ||||
| Component: | New Bugs | Assignee: | Hans Wennborg <hans> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dgrogan, tonyg | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Hans Wennborg
2011-06-14 08:24:37 PDT
Created attachment 97123 [details]
Patch
Comment on attachment 97123 [details]
Patch
So this is a redundant check? We were already checking this at a lower layer, but this is a nicer place to check? I'm confused. what happens if you call db.open() with a non-existant path?
(In reply to comment #2) > (From update of attachment 97123 [details]) > So this is a redundant check? We were already checking this at a lower layer, but this is a nicer place to check? I'm confused. what happens if you call db.open() with a non-existant path? It does a LOG_ERROR about failing to open the file, and returns false. It's not a big deal, but I'd like to get those errors removed from my console. LGTM Committed r88925: <http://trac.webkit.org/changeset/88925> |