| Summary: | Run run-api-tests on bots in debug mode | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dmitry Lomov <dslomov> | ||||||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | aroben, dbates, dslomov, levin, rniwa, slewis, tony, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 57513 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Dmitry Lomov
2011-06-13 15:06:18 PDT
Created attachment 97015 [details]
Proposed fix
Comment on attachment 97015 [details]
Proposed fix
Why only debug mode?
Comment on attachment 97015 [details]
Proposed fix
I see. We should add a comment pointing to the bug which blocks running them in release mode. Otherwise this looks OK.
Created attachment 97017 [details]
Added comment explaining why debug mode only
Comment on attachment 97017 [details]
Added comment explaining why debug mode only
This looks good to me. If no one else has objections, I'll r+ it tomorrow.
Thanks!
Comment on attachment 97017 [details] Added comment explaining why debug mode only View in context: https://bugs.webkit.org/attachment.cgi?id=97017&action=review Jus the one question, otherwise r=me > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:556 > + self.addStep(RunUnitTests) How come we don't need to check for debug here? Comment on attachment 97017 [details] Added comment explaining why debug mode only View in context: https://bugs.webkit.org/attachment.cgi?id=97017&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:556 >> + self.addStep(RunUnitTests) > > How come we don't need to check for debug here? Oh right - good catch! Do we have bots that both build and test? Yes. SnowLeopard Leaks, some QT and GTK bots, and some of the Chromium new-run-webkit-tests bots. Created attachment 97378 [details]
BuildAndTestFactory fixed
Comment on attachment 97378 [details]
BuildAndTestFactory fixed
Something must be wrong. There is no change between this patch and the previous one.
Created attachment 97453 [details]
Uploading correct patch this time
Ugh - sorry for the noise - I do not know what happened.
Comment on attachment 97453 [details] Uploading correct patch this time Clearing flags on attachment: 97453 Committed r89054: <http://trac.webkit.org/changeset/89054> All reviewed patches have been landed. Closing bug. api tests are failing on SL debug tests after this patch was landed: http://build.webkit.org/builders/SnowLeopard%20Intel%20Debug%20%28Tests%29/builds/723 Comment on attachment 97453 [details] Uploading correct patch this time View in context: https://bugs.webkit.org/attachment.cgi?id=97453&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:316 > + command = ["perl", "./Tools/Scripts/run-api-tests"] We should pass the configuration (i.e. Debug/Release) to run-api-tests so that it can call build-api-tests with this configuration. (In reply to comment #15) > We should pass the configuration (i.e. Debug/Release) to run-api-tests so that it can call build-api-tests with this configuration. Dmitry Lomov filed bug #62918 with regards to this issue. |