kAXTextMarkerForPositionParameterizedAttribute does not work correctly in WK2

• Component: Accessibility
• Status: RESOLVED FIXED

[chris fleizach]

With WK2 I am running into some serious issues with the AXTextMarker API. There seems to be a significant change in accessing webkit content. I used to grab the current paragraph of text below the cursor in a webkit view using this strategy: get kAXTextMarkerForPositionParametrizedAttribute, then kAXParagraphTextMarkerRangeForTextMarkerParametrizedAttribute followed by kAXStringForTextMarkerRangeParameterizedAttribute. This seems to give no string or text from a completely different part of the web site.

[chris fleizach]

rdar://9555733

[chris fleizach]

Created attachment 96969 [details]
patch

[WebKit Review Bot]

Attachment 96969 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/WebPageProxy.h:616:  The parameter name "point" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 96969 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96969&action=review

> Source/WebKit2/UIProcess/WebPageProxy.h:610
> +    void screenToWindow(const WebCore::IntPoint& point, WebCore::IntPoint& result);

The stylebot suggests leaving out the name “point” here, and I agree. Unless you want to call this screenPoint.

> Source/WebKit2/UIProcess/WebPageProxy.messages.in:55
> +    ScreenToWindow(WebCore::IntPoint point) -> (WebCore::IntPoint resultPoint)

I’d call these screenPoint and windowPoint rather than point and resultPoint.

[chris fleizach]

http://trac.webkit.org/changeset/88669