Bug 62539 – [EFL] Input method hints not updated while clicking non-input field editable area

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Michal Pakula vel Rutka]

Overview:
On some pages input method hints are not updated while focus is changed from editable area with input tags to other which are does not have input tag i.e. textarea

When input method hints are set by ewk_view_input_method_state_set current input method priv->imh is being reset after an if condition. One of its conditions is that a focused node has to have tag name input. There may be editable areas i.e. textarea are which does not have input tag, and hints remain unchanged.

Steps to reproduce:
Go to http://24ways.org/examples/have-a-field-day-with-html5-forms/24ways-form.html, click on the one of input fields - input method hints should change respectively of an input type. Then click on Address area.

Actual result:
Input method hint remains unchanged

Expected result:
Input method hint should be reset to 0.

[Michal Pakula vel Rutka]

Created attachment 96956 [details]
patch

[Collabora GTK+ EWS bot]

Comment on attachment 96956 [details]
patch

Attachment 96956 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/8831805

[Leandro Pereira]

Comment on attachment 96956 [details]
patch

LGTM. (Also, cq? again, as this isn't touching any GTK-related file.)

[Eric Seidel (no email)]

Comment on attachment 96956 [details]
patch

I don't know how to review this.  I don't think there are any EFL reviewers.  I'm happy to rs=me.  The gtk error looks bogus.

[WebKit Review Bot]

Comment on attachment 96956 [details]
patch

Clearing flags on attachment: 96956

Committed r88725: <http://trac.webkit.org/changeset/88725>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.