Bug 62420

Summary: [Qt] Keep ORIENTATION_EVENTS independent from DEVICE_ORIENTATION
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar, kenneth, qi.2.zhang, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch none

Laszlo Gombos
Reported 2011-06-09 17:56:22 PDT
http://trac.webkit.org/changeset/73584 made ORIENTATION_EVENTS dependent from DEVICE_ORIENTATION, even though these features are interdependently configurable. I think we should keep them independent.
Attachments
proposed patch (2.72 KB, patch)
2011-06-09 18:00 PDT, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2011-06-09 18:00:33 PDT
Created attachment 96680 [details] proposed patch
WebKit Review Bot
Comment 2 2011-06-10 03:06:53 PDT
Comment on attachment 96680 [details] proposed patch Clearing flags on attachment: 96680 Committed r88534: <http://trac.webkit.org/changeset/88534>
WebKit Review Bot
Comment 3 2011-06-10 03:06:58 PDT
All reviewed patches have been landed. Closing bug.
Ademar Reis
Comment 4 2011-06-10 06:19:24 PDT
I guess we should include this fix in 2.2, no? (even though r73584 was included in 2.1.x).
Note You need to log in before you can comment on or make changes to this bug.