Bug 62411 – REGRESSION: End of apple.com video in full-screen mode leads to unusable page.

• Component: Media
• Status: RESOLVED FIXED

[Jer Noble]

REGRESSION: End of apple.com video in full-screen mode leads to unusable page.

[Jer Noble]

Created attachment 96659 [details]
Patch

[WebKit Review Bot]

Attachment 96659 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/rendering/RenderFullScreen.cpp:49:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jer Noble]

<rdar://problem/9583009>

[Darin Adler]

Comment on attachment 96659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96659&action=review

> Source/WebCore/rendering/RenderFullScreen.cpp:47
> +    virtual ~RenderFullScreenPlaceholder() { }

There’s no need for you to define this explicitly.

> Source/WebCore/rendering/RenderFullScreen.cpp:48
> +    virtual bool isRenderFullScreenPlaceholder() const { return true; }

This could be private.

>> Source/WebCore/rendering/RenderFullScreen.cpp:49
>> +    virtual void destroy() {
> 
> Place brace on its own line for function definitions.  [whitespace/braces] [4]

I think this could be private. I think it would be better style to not make this inline.

> Source/WebCore/rendering/RenderFullScreen.cpp:53
> +    RenderFullScreen* m_owner;

This could be private.

[Darin Adler]

Where’s the regression test?

[Jer Noble]

(In reply to comment #5)
> Where’s the regression test?

I'll write one up before landing.  Thanks!

[Jer Noble]

Committed r88591: <http://trac.webkit.org/changeset/88591>