Bug 6241

Summary: Remove WebFrame's parent frame pointer, instead rely on WebCore's parent concept
Product: WebKit Reporter: Maciej Stachowiak <mjs>
Component: WebKit APIAssignee: Maciej Stachowiak <mjs>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
change to do it ggaren: review+

Description Maciej Stachowiak 2005-12-25 17:13:25 PST
WebKit has a redundant frame tree which is not necessarily entirely consistent with the WebCore tree it 
duplicates. As part of removing it and pushing code down, WebFrame should no longer keep a direct 
parent pointer and should count on the one from WebCore.
Comment 1 Maciej Stachowiak 2005-12-25 17:56:38 PST
Created attachment 5280 [details]
change to do it
Comment 2 Geoffrey Garen 2005-12-25 21:45:55 PST
Comment on attachment 5280 [details]
change to do it

Looks good.

I think these lines

	 for (i = [_private->children count]-1; i >=0; i--) {
	     [[_private->children objectAtIndex:i] _detachFromParent];
-	     [_private->children removeObjectAtIndex:i];
	 }

now have braces that don't belong.