Bug 62398

Summary: IndexedDB: indexedDB.open() name argument is required
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dgrogan, hans, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
test case
none
Patch none

Mark Pilgrim (Google)
Reported 2011-06-09 13:32:03 PDT
Created attachment 96629 [details] test case http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBFactory-open-IDBRequest-DOMString-name states that the name argument to open() (for opening a database) is not optional and can not be null. This test opens a database without supplying a name argument. Expected behavior: throws IDBDatabaseException.NON_TRANSIENT_ERR Actual behavior: opens a database whose name is the 9-letter string "undefined" Test case attached.
Attachments
test case (1.54 KB, text/html)
2011-06-09 13:32 PDT, Mark Pilgrim (Google) 		no flags
Details
Patch (4.57 KB, patch)
2011-06-10 11:20 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2011-06-10 11:20:22 PDT
Created attachment 96763 [details] Patch
David Grogan
Comment 2 2011-06-10 13:57:09 PDT
LGTM
WebKit Review Bot
Comment 3 2011-06-10 14:42:40 PDT
Comment on attachment 96763 [details] Patch Clearing flags on attachment: 96763 Committed r88569: <http://trac.webkit.org/changeset/88569>
WebKit Review Bot
Comment 4 2011-06-10 14:42:44 PDT
All reviewed patches have been landed. Closing bug.
Dimitri Glazkov (Google)
Comment 5 2011-06-11 13:22:03 PDT
Reverted r88569 for reason: Broke Chromium browser test: IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest Committed r88606: <http://trac.webkit.org/changeset/88606>
Dimitri Glazkov (Google)
Comment 6 2011-06-11 13:23:05 PDT
(In reply to comment #5) > Reverted r88569 for reason: > > Broke Chromium browser test: IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest > > Committed r88606: <http://trac.webkit.org/changeset/88606> That's the one.
Dimitri Glazkov (Google)
Comment 7 2011-06-11 13:24:37 PDT
(In reply to comment #6) > (In reply to comment #5) > > Reverted r88569 for reason: > > > > Broke Chromium browser test: IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest > > > > Committed r88606: <http://trac.webkit.org/changeset/88606> > > That's the one. There's the test: http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/chrome/test/data/indexeddb/database_callbacks_first.html&exact_package=chromium&q=database_callbacks_first.html&type=cs
Hans Wennborg
Comment 8 2011-06-15 02:16:31 PDT
Fixed the Chromium browser test: http://src.chromium.org/viewvc/chrome?view=rev&revision=89152 We should be able to re-land this now.
WebKit Review Bot
Comment 9 2011-06-15 10:24:43 PDT
Comment on attachment 96763 [details] Patch Clearing flags on attachment: 96763 Committed r88954: <http://trac.webkit.org/changeset/88954>
WebKit Review Bot
Comment 10 2011-06-15 10:24:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.