Summary: | IndexedDB: indexedDB.open() name argument is required | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Pilgrim (Google) <pilgrim> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dglazkov, dgrogan, hans, tony, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Mark Pilgrim (Google)
2011-06-09 13:32:03 PDT
Created attachment 96763 [details]
Patch
LGTM Comment on attachment 96763 [details] Patch Clearing flags on attachment: 96763 Committed r88569: <http://trac.webkit.org/changeset/88569> All reviewed patches have been landed. Closing bug. Reverted r88569 for reason: Broke Chromium browser test: IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest Committed r88606: <http://trac.webkit.org/changeset/88606> (In reply to comment #5) > Reverted r88569 for reason: > > Broke Chromium browser test: IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest > > Committed r88606: <http://trac.webkit.org/changeset/88606> That's the one. (In reply to comment #6) > (In reply to comment #5) > > Reverted r88569 for reason: > > > > Broke Chromium browser test: IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest > > > > Committed r88606: <http://trac.webkit.org/changeset/88606> > > That's the one. There's the test: http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/chrome/test/data/indexeddb/database_callbacks_first.html&exact_package=chromium&q=database_callbacks_first.html&type=cs Fixed the Chromium browser test: http://src.chromium.org/viewvc/chrome?view=rev&revision=89152 We should be able to re-land this now. Comment on attachment 96763 [details] Patch Clearing flags on attachment: 96763 Committed r88954: <http://trac.webkit.org/changeset/88954> All reviewed patches have been landed. Closing bug. |