Bug 62378

Summary: [Qt] Fix the in-tree build on Linux
Product: WebKit Reporter: Andras Becsi <abecsi>
Component: Tools / TestsAssignee: Andras Becsi <abecsi>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar, kling, webkit.review.bot, yael
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
proposed patch none

Andras Becsi
Reported 2011-06-09 08:07:16 PDT
In case of an in-tree build, qmake generates defect prl dependencies for the QtWebKit library on Linux, because the inclusion of qtbase.pri adds explicitlib to CONFIG. This results in linking failure for all Qt applications which use the webkit module.
Attachments
proposed patch (1.48 KB, patch)
2011-06-09 08:19 PDT, Andras Becsi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andras Becsi
Comment 1 2011-06-09 08:19:20 PDT
Created attachment 96592 [details] proposed patch
Andreas Kling
Comment 2 2011-06-09 08:25:52 PDT
Comment on attachment 96592 [details] proposed patch If I could r++ this, I would.
WebKit Review Bot
Comment 3 2011-06-09 09:05:21 PDT
Comment on attachment 96592 [details] proposed patch Clearing flags on attachment: 96592 Committed r88455: <http://trac.webkit.org/changeset/88455>
WebKit Review Bot
Comment 4 2011-06-09 09:05:26 PDT
All reviewed patches have been landed. Closing bug.
Ademar Reis
Comment 5 2011-06-09 11:01:39 PDT
Revision r88455 cherry-picked into qtwebkit-2.2 with commit 8c2f686 <http://gitorious.org/webkit/qtwebkit/commit/8c2f686>
Note You need to log in before you can comment on or make changes to this bug.