Bug 62372 – [CSSRegions] Add build slave

• Component: New Bugs
• Status: RESOLVED FIXED

[Mihnea Ovidenie]

Add a Mac build slave.

[Mihnea Ovidenie]

Machine has the following specs:
CPU: 3.2 GHz Quad-Core Xeon
RAM: 8Gb
OS: Snow Leopard

[Mihnea Ovidenie]

Created attachment 96585 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 96585 [details]
Patch

Sounds fine to me.

[Eric Seidel (no email)]

Comment on attachment 96585 [details]
Patch

I'll let aroben give the official r+

[Adam Roben (:aroben)]

Comment on attachment 96585 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96585&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:242
> +                    { "name": "Adobe SnowLeopard Intel Release (Build)", "type": "Build", "builddir": "adobe-snowleopard-intel-release",

We don't currently have any builders with company names in them. The important thing is the flavor of WebKit that runs on the builder and what kinds of operations it performs, not who maintains the slaves used by that builder. (In fact, you could have multiple different companies that maintain slaves that are used by a single builder.) I'd recommend giving this builder a name that that indicates its purpose.

[Mihnea Ovidenie]

Created attachment 98156 [details]
Patch 2

[Mihnea Ovidenie]

(In reply to comment #5)
> (From update of attachment 96585 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=96585&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:242
> > +                    { "name": "Adobe SnowLeopard Intel Release (Build)", "type": "Build", "builddir": "adobe-snowleopard-intel-release",
> 
> We don't currently have any builders with company names in them. The important thing is the flavor of WebKit that runs on the builder and what kinds of operations it performs, not who maintains the slaves used by that builder. (In fact, you could have multiple different companies that maintain slaves that are used by a single builder.) I'd recommend giving this builder a name that that indicates its purpose.

Hi Adam,

Thanks for your suggestions. We are thinking to use the following steps for this machine for the near future:
Step1: configure it like a SnowLeopard slave build bot to do Mac WebKit Builds
Step2: configure it like a SnowLeopard slave build bot to do Mac WebKit Builds with css-regions/css-exclusions enabled(they are disabled by default)
Step3: configure it like a SnowLeopard slave build bot to do Mac WebKit Builds and Tests with css-regions/css-exclusions enabled. This bot would also run css-regions/css-exclusions specific tests, that are skipped in WebKit main trunk.

Does this sound ok to you?

[Adam Roben (:aroben)]

Comment on attachment 98156 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=98156&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:255
> +                                       "CSSRegions SnowLeopard Intel Release (Build)"]

You should add your new builder to the mac-snowleopard PlatformSpecificScheduler. That way it won't do a build when, e.g., Qt layout test results get updated and nothing else changes.

[Mihnea Ovidenie]

Created attachment 98165 [details]
Patch 3

[WebKit Review Bot]

Comment on attachment 98165 [details]
Patch 3

Clearing flags on attachment: 98165

Committed r90228: <http://trac.webkit.org/changeset/90228>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.