| Summary: | AX: aria-labelledby should be used in preference to aria-labeledby | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alice Boxhall <aboxhall> | ||||||||||||||||||
| Component: | Accessibility | Assignee: | Samuel White <samuel_white> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, samuel_white, webkit-bug-importer, webkit.review.bot | ||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Bug Depends on: | 66745 | ||||||||||||||||||||
| Bug Blocks: | |||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Alice Boxhall
2011-06-08 21:08:12 PDT
Created attachment 96542 [details]
Patch
There may be some opposition to the method name change, but I was finding it confusing to type when the standard is aria-labelledby. Comment on attachment 96542 [details]
Patch
Sorry this took so long to review. r=me
Created attachment 104644 [details]
Patch
Comment on attachment 104644 [details]
Patch
Rebased patch.
Comment on attachment 104644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104644&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1307 > + the last patch did not change this logic. this patch looks like it's now changing what's returned in title Created attachment 104647 [details]
Patch
Comment on attachment 104647 [details]
Patch
Thanks for the quick review; not sure how that extra logic got in the last patch.
Comment on attachment 104647 [details] Patch Clearing flags on attachment: 104647 Committed r93565: <http://trac.webkit.org/changeset/93565> All reviewed patches have been landed. Closing bug. Reopening after rollout. Created attachment 104795 [details]
Patch
Fixed the bug that caused a bunch of test breakages, and updated the test to work with the changes in bug 61995. Comment on attachment 104795 [details]
Patch
Is this ok?
(In reply to comment #14) > (From update of attachment 104795 [details]) > Is this ok? is the windows build failure due to something else? Created attachment 106373 [details]
Patch
(In reply to comment #15) > (In reply to comment #14) > > (From update of attachment 104795 [details] [details]) > > Is this ok? > > is the windows build failure due to something else? Not sure; just uploaded a rebaselined patch; if that fails on Windows I'll check it out. Comment on attachment 106373 [details]
Patch
win build failure
5>..\AccessibleImage.cpp(49) : error C2039: 'ariaLabeledByAttribute' : is not a member of 'WebCore::AccessibilityRenderObject'
5> C:\cygwin\home\buildbot\WebKitBuild\Debug\Include\WebCore/AccessibilityRenderObject.h(58) : see declaration of 'WebCore::AccessibilityRenderObject'
Created attachment 113427 [details]
Patch
Re-submitting patch as it builds for me on Windows now. Created attachment 113430 [details]
Patch
Trying that again without my local hacks... still getting used to Windows. Ok, still not building on EWS. Will look into why. Comment on attachment 113430 [details]
Patch
r- until it builds on windows
Created attachment 217249 [details]
Patch.
Comment on attachment 217249 [details] Patch. Clearing flags on attachment: 217249 Committed r159482: <http://trac.webkit.org/changeset/159482> All reviewed patches have been landed. Closing bug. |