Bug 62350 – [Chromium] Forward shift + up/down key events to text field when autofill popup window is shown.

• Component: New Bugs
• Status: RESOLVED FIXED

[Naoki Takano]

[Chromium] Forward shit + up/down key events to text field when autofill popup window is shown.

[Naoki Takano]

Created attachment 96540 [details]
Patch

[Naoki Takano]

Please review my patch.

[Kent Tamura]

Comment on attachment 96540 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96540&action=review

> Source/WebCore/ChangeLog:5
> +        [Chromium] Forward shit + up/down key events to text field when autofill popup window is shown.

Why do we forward only these specific key combinations?  No need to forward other keys?
What about Command+cursor on Mac?

[Naoki Takano]

Kent-san,

Thank you for your review.

Original bug report only refers to "shift + up". (I typo "shit" though, orz)

Is there any other combination I have to consider?
If shift/control/alt/command keys are appended, do I have to forward all up/down key events?

(In reply to comment #3)
> (From update of attachment 96540 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=96540&action=review
> 
> > Source/WebCore/ChangeLog:5
> > +        [Chromium] Forward shit + up/down key events to text field when autofill popup window is shown.
> 
> Why do we forward only these specific key combinations?  No need to forward other keys?
> What about Command+cursor on Mac?

[Kent Tamura]

(In reply to comment #4)
> Kent-san,
> 
> Thank you for your review.
> 
> Original bug report only refers to "shift + up". (I typo "shit" though, orz)
> 
> Is there any other combination I have to consider?
> If shift/control/alt/command keys are appended, do I have to forward all up/down key events?

I don't know.  You should discuss it with Autofill team and Chrome UX team.

[Naoki Takano]

I know Autofill team, David and Ilya. Actually I already added Ilya here.

But I don't know who are in Chrome UX team.

Do you know them?

Thanks,

(In reply to comment #5)
> (In reply to comment #4)
> > Kent-san,
> > 
> > Thank you for your review.
> > 
> > Original bug report only refers to "shift + up". (I typo "shit" though, orz)
> > 
> > Is there any other combination I have to consider?
> > If shift/control/alt/command keys are appended, do I have to forward all up/down key events?
> 
> I don't know.  You should discuss it with Autofill team and Chrome UX team.

[Ilya Sherman]

(In reply to comment #4)
> Kent-san,
> 
> Thank you for your review.
> 
> Original bug report only refers to "shift + up". (I typo "shit" though, orz)
> 
> Is there any other combination I have to consider?
> If shift/control/alt/command keys are appended, do I have to forward all up/down key events?
> 
> (In reply to comment #3)
> > (From update of attachment 96540 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=96540&action=review
> > 
> > > Source/WebCore/ChangeLog:5
> > > +        [Chromium] Forward shit + up/down key events to text field when autofill popup window is shown.
> > 
> > Why do we forward only these specific key combinations?  No need to forward other keys?
> > What about Command+cursor on Mac?

If we want to be absolutely perfect, we should probably forward more key combinations.  For example, on Mac, option-up/down should move the cursor without selecting text.  On the other hand, the ideal behavior for ctrl-up/down is to jump to the top/bottom of the popup list.  That's on Mac -- I'm not as sure what the behavior should be on the other platforms.

That said, I am fine with forwarding either only key combinations involving shift, as shift-up/down is by far the most common cursor movement of this sort.  I am also fine with forwarding all key presses with modifiers, and only intercepting literal up/down arrow presses.

David, Glen, any thoughts to add into the mix?

[Naoki Takano]

David and Glen,

Could you give us your thoughts?

Thanks,

(In reply to comment #7)
> (In reply to comment #4)
> > Kent-san,
> > 
> > Thank you for your review.
> > 
> > Original bug report only refers to "shift + up". (I typo "shit" though, orz)
> > 
> > Is there any other combination I have to consider?
> > If shift/control/alt/command keys are appended, do I have to forward all up/down key events?
> > 
> > (In reply to comment #3)
> > > (From update of attachment 96540 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=96540&action=review
> > > 
> > > > Source/WebCore/ChangeLog:5
> > > > +        [Chromium] Forward shit + up/down key events to text field when autofill popup window is shown.
> > > 
> > > Why do we forward only these specific key combinations?  No need to forward other keys?
> > > What about Command+cursor on Mac?
> 
> If we want to be absolutely perfect, we should probably forward more key combinations.  For example, on Mac, option-up/down should move the cursor without selecting text.  On the other hand, the ideal behavior for ctrl-up/down is to jump to the top/bottom of the popup list.  That's on Mac -- I'm not as sure what the behavior should be on the other platforms.
> 
> That said, I am fine with forwarding either only key combinations involving shift, as shift-up/down is by far the most common cursor movement of this sort.  I am also fine with forwarding all key presses with modifiers, and only intercepting literal up/down arrow presses.
> 
> David, Glen, any thoughts to add into the mix?

[Glen Murphy]

Ilya's proposal of forwarding all keypresses with modifiers sounds good to me.

[David Holloway]

(In reply to comment #9)
> Ilya's proposal of forwarding all keypresses with modifiers sounds good to me.

Yes, sounds good to me.

[Naoki Takano]

Thanks, guys.

I'll do that.

(In reply to comment #10)
> (In reply to comment #9)
> > Ilya's proposal of forwarding all keypresses with modifiers sounds good to me.
> 
> Yes, sounds good to me.

[Naoki Takano]

Created attachment 97071 [details]
Patch

[Kent Tamura]

Comment on attachment 97071 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97071&action=review

> Source/WebCore/ChangeLog:11
> +        * manual-tests/autofill-popup-shiftupdown.hml: Added to check modifier + up/down key is working correctly for text area in autofill popup is shown.

This test is Chromium-specific.  It should be put to WebCore/manual-tests/chromium/.

[Naoki Takano]

Created attachment 97211 [details]
Patch

[Kent Tamura]

Comment on attachment 97211 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97211&action=review

> Source/WebCore/ChangeLog:11
> +        Manual test: autofill-popup-shiftupdown.html
> +
> +        * manual-tests/autofill-popup-shiftupdown.hml: Added to check modifier + up/down key is working correctly for text area in autofill popup is shown.

Need to update ChangeLog

[Naoki Takano]

Created attachment 97219 [details]
Patch

[Kent Tamura]

Comment on attachment 97219 [details]
Patch

Looks ok.

[Naoki Takano]

Thank, kent-san!!

(In reply to comment #17)
> (From update of attachment 97219 [details])
> Looks ok.

[WebKit Review Bot]

Comment on attachment 97219 [details]
Patch

Clearing flags on attachment: 97219

Committed r88895: <http://trac.webkit.org/changeset/88895>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.