Bug 62338

Summary: Avoid flashing when exiting full-screen mode.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: MediaAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, darin, jeffm, sam
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Description Jer Noble 2011-06-08 16:29:59 PDT 
Avoid flashing when exiting full-screen mode.
Comment 1 Jer Noble 2011-06-09 11:34:59 PDT 
Created attachment 96609 [details]
Patch
Comment 2 Jer Noble 2011-06-09 11:43:33 PDT 
<rdar://problem/9432741>
Comment 3 Jer Noble 2011-06-09 11:44:24 PDT 
From my testing, this patch appears to reduce the flashing to 0 during both entering full-screen and exiting full-screen.
Comment 4 Darin Adler 2011-06-09 11:50:33 PDT 
Comment on attachment 96609 [details]
Patch

Anders, Sam, do you have any comments on this approach?
Comment 5 Jer Noble 2011-06-10 20:02:45 PDT 
Comment on attachment 96609 [details]
Patch

Obseleting this patch.  A new one (which uses fewer synchronous messages) will follow shortly.
Comment 6 Jer Noble 2011-06-11 00:30:04 PDT 
Created attachment 96846 [details]
Patch

Addressed Anders\' comments.  No longer need to make any of the full-screen inter-process messages synchronous.
Comment 7 Anders Carlsson 2011-06-11 06:53:55 PDT 
Comment on attachment 96846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96846&action=review

> Source/WebKit2/ChangeLog:25
> +            screen updates, to be re-enabled during exitAcceleratedCompositingMOde.

Typo, MOde.
Comment 8 Jer Noble 2011-06-13 11:05:18 PDT 
Committed r88654: <http://trac.webkit.org/changeset/88654>