|Summary:||IndexedDB test: odd database names|
|Product:||WebKit||Reporter:||Mark Pilgrim (Google) <pilgrim>|
|Component:||New Bugs||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||dgrogan, hans, tony, webkit.review.bot|
|Version:||528+ (Nightly build)|
Description Mark Pilgrim (Google) 2011-06-08 14:10:12 PDT
http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#database-concept states "Every database has a name which identifies it within a specific origin. The name can be any string value. ... Implementations must support all names. If a implementation uses a storage mechanism which can't handle arbitrary database names, the implementation must use an escaping mechanism or something similar to map the provided name to a name that it can handle." This test creates a series of databases with names as odd Unicode characters (null, surrogate code points, non-BMP characters, etc) that are traditionally problematic for storage systems. WebKit passes this test.
Comment 2 David Grogan 2011-06-08 14:15:48 PDT
Comment on attachment 96476 [details] Patch Could you add another couple of steps here: add data to each objectstore, close it, reopen it with the crazy name and ensure the data is still there?
Comment 3 Mark Pilgrim (Google) 2011-06-08 20:08:56 PDT
Good call, there are some string keys which are not stored and/or retrieved properly. Tracked separately as bug 62348.
Comment 4 Eric Seidel (no email) 2011-06-13 15:21:36 PDT
Comment on attachment 96476 [details] Patch I like tests!
Comment 5 WebKit Review Bot 2011-06-13 15:30:01 PDT
Comment on attachment 96476 [details] Patch Clearing flags on attachment: 96476 Committed r88713: <http://trac.webkit.org/changeset/88713>
Comment 6 WebKit Review Bot 2011-06-13 15:30:05 PDT
All reviewed patches have been landed. Closing bug.