Bug 6230

Summary: Remove QDict from khtml/html
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: WebKit Misc.Assignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Enhancement    
Priority: P4    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 6295    
Attachments:
Description Flags
proposed patch. mjs: review+

Eric Seidel (no email)
Reported 2005-12-24 10:49:21 PST
Remove QDict from khtml/html Patch attached. I expect this will make things faster too... testing now.
Attachments
proposed patch. (10.12 KB, patch)
2005-12-24 10:49 PST, Eric Seidel (no email) 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2005-12-24 10:49:43 PST
Created attachment 5270 [details] proposed patch.
Eric Seidel (no email)
Comment 2 2005-12-24 11:29:35 PST
This was another (small) performance win.
Maciej Stachowiak
Comment 3 2005-12-24 22:34:13 PST
Comment on attachment 5270 [details] proposed patch. + info->idCache.add(idAttrVal.impl(), idVector); I think it would be better to use set() instead of add() here, just because it has a more obvious semantic. On the other hand, it would be a leak (with either set or add!) if there were already a value set for that id, so maybe ASSERT that that's not the case? Same comment: + info->nameCache.add(nameAttrVal.impl(), nameVector); These both come up more than once. r=me despite this minor style nitpick.
Eric Seidel (no email)
Comment 4 2005-12-29 19:31:12 PST
Those won't leak as written (they check for existance first before creating). However, these could be done in one-pass by checking the result of add(), but I'll leave that for another patch.
Note You need to log in before you can comment on or make changes to this bug.